Allow choice of specific python release #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you're building on a system with multiple versions of Python available, it can be very hard to make OCIO build against a specific version. In particular, https://cmake.org/cmake/help/latest/module/FindPython.html explains that FindPython looks preferably for version 3 of Python. Signed-off-by: Larry Gritz <lg@larrygritz.com>
michdolan
reviewed
Jun 14, 2021
* Rename OCIO_PREFERRED_PYTHON_VERSION -> OCIO_PYTHON_VERSION. * Move the cached variable to the top level CMakeLists.txt instead of in FindExtPackages.cmake. * Warning if OCIO_PYTHON_VERSION is set but OCIO_BUILD_PYTHON is off. Signed-off-by: Larry Gritz <lg@larrygritz.com>
|
PR amended with the review suggestions. |
hodoulp
approved these changes
Jun 14, 2021
doug-walker
approved these changes
Jun 19, 2021
hodoulp
added a commit
that referenced
this pull request
Jun 28, 2021
* Allow choice of specific python release If you're building on a system with multiple versions of Python available, it can be very hard to make OCIO build against a specific version. In particular, https://cmake.org/cmake/help/latest/module/FindPython.html explains that FindPython looks preferably for version 3 of Python. Signed-off-by: Larry Gritz <lg@larrygritz.com> * Amendments based on review comments: * Rename OCIO_PREFERRED_PYTHON_VERSION -> OCIO_PYTHON_VERSION. * Move the cached variable to the top level CMakeLists.txt instead of in FindExtPackages.cmake. * Warning if OCIO_PYTHON_VERSION is set but OCIO_BUILD_PYTHON is off. Signed-off-by: Larry Gritz <lg@larrygritz.com> Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com>
doug-walker
added a commit
that referenced
this pull request
Jul 12, 2021
* Allow choice of specific python release If you're building on a system with multiple versions of Python available, it can be very hard to make OCIO build against a specific version. In particular, https://cmake.org/cmake/help/latest/module/FindPython.html explains that FindPython looks preferably for version 3 of Python. Signed-off-by: Larry Gritz <lg@larrygritz.com> * Amendments based on review comments: * Rename OCIO_PREFERRED_PYTHON_VERSION -> OCIO_PYTHON_VERSION. * Move the cached variable to the top level CMakeLists.txt instead of in FindExtPackages.cmake. * Warning if OCIO_PYTHON_VERSION is set but OCIO_BUILD_PYTHON is off. Signed-off-by: Larry Gritz <lg@larrygritz.com> Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com> Co-authored-by: Larry Gritz <lg@larrygritz.com> Co-authored-by: doug-walker <43830961+doug-walker@users.noreply.github.com>
Sarcasm
added a commit
to Sarcasm/OpenColorIO
that referenced
this pull request
Oct 22, 2021
This duplicate seems to come from the PR AcademySoftwareFoundation#1371. This PR spanned April 15 - August 24 (2021). Meanwhile, PR AcademySoftwareFoundation#1410 (June 13 - June 21), changed the CMake logic around `find_package(pybind11 ...)`. Looks like former PR mishandled the merge of the latter.
Sarcasm
added a commit
to Sarcasm/OpenColorIO
that referenced
this pull request
Oct 22, 2021
This duplicate seems to come from the PR AcademySoftwareFoundation#1371. This PR spanned April 15 - August 24 (2021). Meanwhile, PR AcademySoftwareFoundation#1410 (June 13 - June 21), changed the CMake logic around `find_package(pybind11 ...)`. Looks like former PR mishandled the merge of the latter.
Sarcasm
added a commit
to Sarcasm/OpenColorIO
that referenced
this pull request
Oct 22, 2021
This duplicate seems to come from the PR AcademySoftwareFoundation#1371. This PR spanned April 15 - August 24 (2021). Meanwhile, PR AcademySoftwareFoundation#1410 (June 13 - June 21), changed the CMake logic around `find_package(pybind11 ...)`. It looks like former PR mishandled the merge of the latter.
Sarcasm
added a commit
to Sarcasm/OpenColorIO
that referenced
this pull request
Oct 22, 2021
This duplicate seems to come from the PR AcademySoftwareFoundation#1371. This PR spanned April 15 - August 24 (2021). Meanwhile, PR AcademySoftwareFoundation#1410 (June 13 - June 21), changed the CMake logic around `find_package(pybind11 ...)`. It looks like former PR mishandled the merge of the latter.
Sarcasm
added a commit
to Sarcasm/OpenColorIO
that referenced
this pull request
Oct 22, 2021
This duplicate seems to come from the PR AcademySoftwareFoundation#1371. This PR spanned April 15 - August 24 (2021). Meanwhile, PR AcademySoftwareFoundation#1410 (June 13 - June 21), changed the CMake logic around `find_package(pybind11 ...)`. It looks like former PR mishandled the merge of the latter. Signed-off-by: Guillaume Papin <guillaume.papin@epitech.eu>
hodoulp
pushed a commit
that referenced
this pull request
Oct 26, 2021
This duplicate seems to come from the PR #1371. This PR spanned April 15 - August 24 (2021). Meanwhile, PR #1410 (June 13 - June 21), changed the CMake logic around `find_package(pybind11 ...)`. It looks like former PR mishandled the merge of the latter. Signed-off-by: Guillaume Papin <guillaume.papin@epitech.eu>
hodoulp
pushed a commit
that referenced
this pull request
Oct 26, 2021
This duplicate seems to come from the PR #1371. This PR spanned April 15 - August 24 (2021). Meanwhile, PR #1410 (June 13 - June 21), changed the CMake logic around `find_package(pybind11 ...)`. It looks like former PR mishandled the merge of the latter. Signed-off-by: Guillaume Papin <guillaume.papin@epitech.eu>
hodoulp
added a commit
that referenced
this pull request
Oct 26, 2021
This duplicate seems to come from the PR #1371. This PR spanned April 15 - August 24 (2021). Meanwhile, PR #1410 (June 13 - June 21), changed the CMake logic around `find_package(pybind11 ...)`. It looks like former PR mishandled the merge of the latter. Signed-off-by: Guillaume Papin <guillaume.papin@epitech.eu> Co-authored-by: Guillaume Papin <guillaume.papin@epitech.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're building on a system with multiple versions of Python available,
it can be very hard to make OCIO build against a specific version. In
particular, https://cmake.org/cmake/help/latest/module/FindPython.html
explains that FindPython looks preferably for version 3 of Python.
This situation doesn't really come up in the CI, because all of the containers
have only one version of python each -- the one you are trying to use.
But often people are building on systems with several versions of Python.
I also removed a comment about pybind11 2.4.3 that no longer seems
relevant since we're asking for 2.6.1 or higher.
Signed-off-by: Larry Gritz lg@larrygritz.com