Port from RB-2.0 to master - Allow choice of specific python release (#1410) #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow choice of specific python release If you're building on a system with multiple versions of Python available, it can be very hard to make OCIO build against a specific version. In particular, https://cmake.org/cmake/help/latest/module/FindPython.html explains that FindPython looks preferably for version 3 of Python. Signed-off-by: Larry Gritz <lg@larrygritz.com> * Amendments based on review comments: * Rename OCIO_PREFERRED_PYTHON_VERSION -> OCIO_PYTHON_VERSION. * Move the cached variable to the top level CMakeLists.txt instead of in FindExtPackages.cmake. * Warning if OCIO_PYTHON_VERSION is set but OCIO_BUILD_PYTHON is off. Signed-off-by: Larry Gritz <lg@larrygritz.com> Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com>
lgritz
approved these changes
Jun 28, 2021
michdolan
approved these changes
Jul 10, 2021
doug-walker
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're building on a system with multiple versions of Python available,
it can be very hard to make OCIO build against a specific version. In
particular, https://cmake.org/cmake/help/latest/module/FindPython.html
explains that FindPython looks preferably for version 3 of Python.
Signed-off-by: Larry Gritz lg@larrygritz.com
Amendments based on review comments:
Rename OCIO_PREFERRED_PYTHON_VERSION -> OCIO_PYTHON_VERSION.
Move the cached variable to the top level CMakeLists.txt instead of in
FindExtPackages.cmake.
Warning if OCIO_PYTHON_VERSION is set but OCIO_BUILD_PYTHON is off.
Signed-off-by: Larry Gritz lg@larrygritz.com
Co-authored-by: Patrick Hodoul patrick.hodoul@autodesk.com