-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConfigTest - Virtual display python unit test #1481
ConfigTest - Virtual display python unit test #1481
Conversation
… tests. Signed-off-by: Mei Chu <meimchu@gmail.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
There is few minor code improvements but the core is here.
Concerning the platform specific tests I suggest to forget them for short-term because it requires to find out the platform (possible with Python) but also having the headless mode i.e. OCIO_HEADLESS_ENABLED
. The latter is currently not available for Python unit tests.
That could be a 'follow-up' branch.
Thanks for your contribution @meimchu ! |
(Re-launched the Wheel jobs, there was an issue with Chocolatey failing to install the |
@meimchu Do you know when you will have some time to finalize the pull request? |
Absolutely. Sorry for the delay. I will take a look at this this week!. |
Signed-off-by: Mei Chu <meimchu@gmail.com>
…hub.com/meimchu/OpenColorIO into feature/virtual_display_python_unittest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
You can push another commit to fix the few formatting glitches but the pull request is ready.
Signed-off-by: Mei Chu <meimchu@gmail.com>
…hub.com/meimchu/OpenColorIO into feature/virtual_display_python_unittest
* -ConfigTest: Python unit test updated with additional virtual display tests. Signed-off-by: Mei Chu <meimchu@gmail.com> * -ConfigTest: Addressed feedbacks. Signed-off-by: Mei Chu <meimchu@gmail.com> * -ConfigTest: Addressing feedbacks on typos. Signed-off-by: Mei Chu <meimchu@gmail.com> Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com>
* -ConfigTest: Python unit test updated with additional virtual display tests. Signed-off-by: Mei Chu <meimchu@gmail.com> * -ConfigTest: Addressed feedbacks. Signed-off-by: Mei Chu <meimchu@gmail.com> * -ConfigTest: Addressing feedbacks on typos. Signed-off-by: Mei Chu <meimchu@gmail.com> Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com> Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
* -ConfigTest: Python unit test updated with additional virtual display tests. Signed-off-by: Mei Chu <meimchu@gmail.com> * -ConfigTest: Addressed feedbacks. Signed-off-by: Mei Chu <meimchu@gmail.com> * -ConfigTest: Addressing feedbacks on typos. Signed-off-by: Mei Chu <meimchu@gmail.com> Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com> Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com> Co-authored-by: Mei Chu <33743518+meimchu@users.noreply.github.com>
ConfigTest: Python unit test updated with additional virtual display unit tests. Accompanying features introduced in #1464
Follow up questions and comments:
test_virtual_display()
method alone for now. Let me know if you think my new ConfigVirtualDisplayTest provides sufficient coverage so that can be removed.Signed-off-by: Mei Chu meimchu@gmail.com