Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigTest - Virtual display python unit test #1481

Conversation

meimchu
Copy link
Contributor

@meimchu meimchu commented Sep 5, 2021

ConfigTest: Python unit test updated with additional virtual display unit tests. Accompanying features introduced in #1464

Follow up questions and comments:

  • I would like to ask for some guidance on the cpp part of the unit tests which deal with the different OS platforms. What would be the right way to implement that logic in the python side? Thanks!
  • I have left the test_virtual_display() method alone for now. Let me know if you think my new ConfigVirtualDisplayTest provides sufficient coverage so that can be removed.
  • I mainly followed closely to the virtual display-related unit tests I saw in the cpp unit tests per suggestion. There are some still more "traditional" testings that I can add to it later as well.

Signed-off-by: Mei Chu meimchu@gmail.com

… tests.

Signed-off-by: Mei Chu <meimchu@gmail.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 5, 2021

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@hodoulp hodoulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
There is few minor code improvements but the core is here.

Concerning the platform specific tests I suggest to forget them for short-term because it requires to find out the platform (possible with Python) but also having the headless mode i.e. OCIO_HEADLESS_ENABLED. The latter is currently not available for Python unit tests.
That could be a 'follow-up' branch.

tests/python/ConfigTest.py Outdated Show resolved Hide resolved
tests/python/ConfigTest.py Outdated Show resolved Hide resolved
tests/python/ConfigTest.py Show resolved Hide resolved
tests/python/ConfigTest.py Outdated Show resolved Hide resolved
tests/python/ConfigTest.py Outdated Show resolved Hide resolved
tests/python/ConfigTest.py Outdated Show resolved Hide resolved
tests/python/ConfigTest.py Outdated Show resolved Hide resolved
tests/python/ConfigTest.py Outdated Show resolved Hide resolved
@michdolan
Copy link
Collaborator

michdolan commented Oct 4, 2021

Thanks for your contribution @meimchu !

@remia
Copy link
Collaborator

remia commented Oct 4, 2021

(Re-launched the Wheel jobs, there was an issue with Chocolatey failing to install the doxygen package. I already saw that a few time and have no real idea on where it comes from but most likely an issue on their side.)

@hodoulp
Copy link
Member

hodoulp commented Oct 25, 2021

@meimchu Do you know when you will have some time to finalize the pull request?

@meimchu
Copy link
Contributor Author

meimchu commented Oct 26, 2021

@meimchu Do you know when you will have some time to finalize the pull request?

Absolutely. Sorry for the delay. I will take a look at this this week!.

Copy link
Member

@hodoulp hodoulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

You can push another commit to fix the few formatting glitches but the pull request is ready.

tests/python/ConfigTest.py Show resolved Hide resolved
tests/python/ConfigTest.py Outdated Show resolved Hide resolved
tests/python/ConfigTest.py Show resolved Hide resolved
@michdolan michdolan merged commit f0c1ea2 into AcademySoftwareFoundation:master Oct 31, 2021
hodoulp added a commit that referenced this pull request Nov 1, 2021
* -ConfigTest: Python unit test updated with additional virtual display tests.

Signed-off-by: Mei Chu <meimchu@gmail.com>

* -ConfigTest: Addressed feedbacks.

Signed-off-by: Mei Chu <meimchu@gmail.com>

* -ConfigTest: Addressing feedbacks on typos.
Signed-off-by: Mei Chu <meimchu@gmail.com>

Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com>
hodoulp added a commit that referenced this pull request Nov 1, 2021
* -ConfigTest: Python unit test updated with additional virtual display tests.

Signed-off-by: Mei Chu <meimchu@gmail.com>

* -ConfigTest: Addressed feedbacks.

Signed-off-by: Mei Chu <meimchu@gmail.com>

* -ConfigTest: Addressing feedbacks on typos.
Signed-off-by: Mei Chu <meimchu@gmail.com>

Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com>
Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
hodoulp added a commit that referenced this pull request Nov 2, 2021
* -ConfigTest: Python unit test updated with additional virtual display tests.

Signed-off-by: Mei Chu <meimchu@gmail.com>

* -ConfigTest: Addressed feedbacks.

Signed-off-by: Mei Chu <meimchu@gmail.com>

* -ConfigTest: Addressing feedbacks on typos.
Signed-off-by: Mei Chu <meimchu@gmail.com>

Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com>
Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>

Co-authored-by: Mei Chu <33743518+meimchu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants