Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove honzon global paramter #2071

Merged
merged 6 commits into from
May 5, 2022
Merged

Remove honzon global paramter #2071

merged 6 commits into from
May 5, 2022

Conversation

syan095
Copy link
Contributor

@syan095 syan095 commented May 3, 2022

Also updated how interest rates are queried in cdp-engine module

Closes #2006

Roy Yang added 2 commits May 3, 2022 13:18
Updated tests and configs accordingly
@syan095 syan095 marked this pull request as draft May 3, 2022 05:54
@syan095 syan095 requested a review from xlc May 3, 2022 05:55
@syan095
Copy link
Contributor Author

syan095 commented May 3, 2022

Currently get_interest_rate_per_sec is only called by accumulate_interest, which is infallible.
@xlc can you confirm that we do not need to gate keep people from using collaterals without interest rate set (in adjust_position)?

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #2071 (f0cb299) into master (200e653) will increase coverage by 0.54%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #2071      +/-   ##
==========================================
+ Coverage   85.96%   86.50%   +0.54%     
==========================================
  Files          96       98       +2     
  Lines       19424    21148    +1724     
==========================================
+ Hits        16698    18295    +1597     
- Misses       2726     2853     +127     
Impacted Files Coverage Δ
modules/cdp-engine/src/lib.rs 75.00% <70.00%> (+0.09%) ⬆️
modules/cdp-engine/src/tests.rs 100.00% <100.00%> (ø)
modules/homa-lite/src/mock_no_fees.rs 63.46% <0.00%> (ø)
modules/currencies/src/tests.rs 100.00% <0.00%> (ø)
modules/currencies/src/lib.rs 77.31% <0.00%> (ø)
modules/evm/src/tests.rs 99.27% <0.00%> (+<0.01%) ⬆️
modules/evm/src/lib.rs 62.65% <0.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 200e653...f0cb299. Read the comment docs.

modules/cdp-engine/src/lib.rs Outdated Show resolved Hide resolved
modules/cdp-engine/src/lib.rs Outdated Show resolved Hide resolved
@syan095 syan095 marked this pull request as ready for review May 4, 2022 20:37
@xlc xlc requested a review from ferrell-code May 5, 2022 05:23
xlc
xlc previously approved these changes May 5, 2022
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but lgtm

modules/cdp-engine/src/lib.rs Show resolved Hide resolved
modules/cdp-engine/src/tests.rs Outdated Show resolved Hide resolved
@xlc xlc enabled auto-merge (squash) May 5, 2022 21:56
@xlc xlc merged commit 5afa53f into master May 5, 2022
@xlc xlc deleted the remove-honzon-global-paramter branch May 5, 2022 22:19
syan095 pushed a commit that referenced this pull request May 8, 2022
…rrencyIds

* origin/master:
  add xcm instruction RefundSurplus after Transact (#2088)
  rm dex share duplicate code (#2089)
  precompile (#2049)
  Remove honzon global paramter (#2071)
  update orml (#2077)
  Auto publish predeploy contracts (#2076)

# Conflicts:
#	modules/cdp-engine/src/lib.rs
#	modules/cdp-engine/src/tests.rs
#	runtime/acala/src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove honzon global parameters
3 participants