Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm dex share duplicate code #2089

Merged
merged 2 commits into from
May 7, 2022
Merged

rm dex share duplicate code #2089

merged 2 commits into from
May 7, 2022

Conversation

zqhxuyuan
Copy link
Contributor

No description provided.

@zqhxuyuan zqhxuyuan requested a review from zjb0807 May 6, 2022 14:19
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #2089 (05b319d) into master (0871aa7) will increase coverage by 0.80%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #2089      +/-   ##
==========================================
+ Coverage   85.96%   86.76%   +0.80%     
==========================================
  Files          99      100       +1     
  Lines       20086    21684    +1598     
==========================================
+ Hits        17266    18815    +1549     
- Misses       2820     2869      +49     
Impacted Files Coverage Δ
modules/asset-registry/src/lib.rs 64.70% <50.00%> (+4.15%) ⬆️
primitives/src/currency.rs
modules/currencies/src/lib.rs 77.31% <0.00%> (ø)
modules/currencies/src/tests.rs 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0871aa7...05b319d. Read the comment docs.

@zqhxuyuan zqhxuyuan merged commit 59339f9 into master May 7, 2022
@zqhxuyuan zqhxuyuan deleted the ref-duplicate-code branch May 7, 2022 01:03
syan095 pushed a commit that referenced this pull request May 8, 2022
…rrencyIds

* origin/master:
  add xcm instruction RefundSurplus after Transact (#2088)
  rm dex share duplicate code (#2089)
  precompile (#2049)
  Remove honzon global paramter (#2071)
  update orml (#2077)
  Auto publish predeploy contracts (#2076)

# Conflicts:
#	modules/cdp-engine/src/lib.rs
#	modules/cdp-engine/src/tests.rs
#	runtime/acala/src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants