Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove composer.lock #31

Merged
merged 1 commit into from
Sep 5, 2020
Merged

Remove composer.lock #31

merged 1 commit into from
Sep 5, 2020

Commits on Jul 9, 2020

  1. Remove composer.lock

    - composer.lock shouldn't be commited with a library
    - currently not all unit tests are green because an outdated version of
      egulias/email-validator is installed, triggering an error in modern PHP
      versions, e.g. `Trying to access array offset on value of type null`
      in `vendor/egulias/email-validator/EmailValidator/Parser/Parser.php:147`
    
    The proper way is to:
    - ignore and remove the lock file for libs
    - run `composer update` (this is also future compatiable with composer 2)
    
    To go the extra mile, it's good practice to run a test matrix additionally
    arguments to composer, e.g. `--prefer-lowest` and `--prefer-stable`
    mfn committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    73bb125 View commit details
    Browse the repository at this point in the history