Remove composer.lock #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- composer.lock shouldn't be commited with a library - currently not all unit tests are green because an outdated version of egulias/email-validator is installed, triggering an error in modern PHP versions, e.g. `Trying to access array offset on value of type null` in `vendor/egulias/email-validator/EmailValidator/Parser/Parser.php:147` The proper way is to: - ignore and remove the lock file for libs - run `composer update` (this is also future compatiable with composer 2) To go the extra mile, it's good practice to run a test matrix additionally arguments to composer, e.g. `--prefer-lowest` and `--prefer-stable`
|
Travis integration being unreliable, but the PR is green => https://travis-ci.org/github/wildbit/swiftmailer-postmark/builds/706395975 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
egulias/email-validator is installed, triggering an error in modern PHP
versions, e.g.
Trying to access array offset on value of type nullin
vendor/egulias/email-validator/EmailValidator/Parser/Parser.php:147The proper way is to:
composer update(this is also future compatiable with composer 2)To go the extra mile, it's good practice to run a test matrix additionally
arguments to composer, e.g.
--prefer-lowestand--prefer-stableNote: this was also included in #27