Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlay alignment #6

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Fix overlay alignment #6

merged 1 commit into from
Dec 2, 2022

Conversation

Sloy
Copy link
Member

@Sloy Sloy commented Dec 2, 2022

Originally, this library used to show the overlay items aligned to the right. That's why the icons are on the right side of the list. This behaviour was accidentally broken on some internal refactor previous to publishing the library.

I found the bug and fixed it. It was caused by the missing parent parameter in the ViewHolder inflation.

Before After

@Sloy Sloy requested a review from alorma December 2, 2022 16:27
@alorma alorma merged commit 9e62599 into main Dec 2, 2022
@alorma alorma deleted the fix-alignment branch December 2, 2022 18:03
@alorma
Copy link
Member

alorma commented Dec 2, 2022

Thanks @Sloy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants