Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlay alignment #6

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Fix overlay alignment #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../src/main/java/com/adevinta/android/taggingviewer/internal/view/TagEntryItemViewHolder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ internal class TagEntryItemViewHolder(binding: TaggingViewItemBinding) : ViewHol
companion object {
fun build(parent: ViewGroup): TagEntryItemViewHolder {
val inflater = LayoutInflater.from(parent.context)
val binding = TaggingViewItemBinding.inflate(inflater)
val binding = TaggingViewItemBinding.inflate(inflater, parent, false)
return TagEntryItemViewHolder(binding)
}
}
Expand Down
7 changes: 4 additions & 3 deletions taggingviewer/src/main/res/layout/tagging_view_item.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="wrap_content"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_gravity="right"
>

<LinearLayout
Expand Down
1 change: 0 additions & 1 deletion taggingviewer/src/main/res/layout/tagging_view_wrapper.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
<com.adevinta.android.taggingviewer.internal.view.TaggingOverlayListView
android:id="@+id/tagging_viewer_tags_list"
android:layout_width="match_parent"
android:layout_gravity="end"
android:layout_height="wrap_content"
android:paddingBottom="8dp"
android:paddingTop="8dp"
Expand Down