chore: switch to E.when for promise-space onResolve hook

This is more defensive against sneaky promises, at the cost of delaying storage by a turn for non-promises.
Agoric · May 12, 2023 · 9d57c66 · 9d57c66
1 parent ec7cea6
commit 9d57c66
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/packages/vats/package.json b/packages/vats/package.json
@@ -42,6 +42,7 @@
     "@agoric/vat-data": "^0.4.3",
     "@agoric/zoe": "^0.25.3",
     "@agoric/zone": "^0.1.0",
+    "@endo/eventual-send": "^0.17.2",
     "@endo/far": "^0.2.18",
     "@endo/import-bundle": "^0.3.4",
     "@endo/init": "^0.5.56",

diff --git a/packages/vats/src/core/promise-space.js b/packages/vats/src/core/promise-space.js
@@ -1,7 +1,8 @@
 // @ts-check
+import { E } from '@endo/eventual-send';
 import { assertKey } from '@agoric/store';
 import { canBeDurable } from '@agoric/vat-data';
-import { isPromise, makePromiseKit } from '@endo/promise-kit';
+import { makePromiseKit } from '@endo/promise-kit';
 
 /**
  * @typedef {{
@@ -59,11 +60,7 @@ export const makeStoreHooks = (store, log = noop) => {
   return harden({
     ...logHooks,
     onResolve: (name, valueP) => {
-      if (isPromise(valueP)) {
-        void valueP.then(value => save(name, value));
-      } else {
-        save(name, valueP);
-      }
+      void E.when(valueP, value => save(name, value));
     },
     onReset: name => {
       if (store.has(name)) {

diff --git a/packages/vats/test/test-promise-space.js b/packages/vats/test/test-promise-space.js
@@ -64,6 +64,7 @@ test('makePromiseSpace copied into store', async t => {
     produce.chocolate.resolve(doesNotResolve);
     const nonPassable = harden(() => {});
     produce.strawberry.resolve(nonPassable);
+    await null;
     const actual = Object.fromEntries(store.entries());
     t.deepEqual(
       actual,