get rid of <[Object: null prototype] {}> console noise #2324

erights · 2021-02-03T04:19:40Z

After applying both #2303 and endojs/endo#569 , a yarn test fails in something having to do with xsnap, complaining about an assignment to a constructor property failing.

Low priority because endojs/endo#569 is low priority. But fixing this would cause the Node console to stop adding junk like the following to its display of objects.

[Function (anonymous)] Function <Function <[Object: null prototype] {}>>

The text was updated successfully, but these errors were encountered:

erights · 2021-02-10T00:36:53Z

When linking master of agoric-sdk with https://github.com/Agoric/SES-shim/pull/569` i.e., https://github.com/Agoric/SES-shim/tree/markm-stop-enabling-O-p-constructor and then doing a yarn test I get lots of error output in which this seems to be the key diagnostic:

    message: 'Cannot assign to read only property \'constructor\' of object \'[object Object]\' in /Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/whitelist.js',

However, this is unlikely to be a problem in the source code of whitelist.js since it doesn't have this problem otherwise. But perhaps?

This diagnostic appears within the following longer sample

Replaying SwingSet transcripts
Replaying SwingSet transcripts
  devices › before hook

  Rejected promise returned by test. Reason:

  TypeError {
    code: 'PLUGIN_ERROR',
    hook: 'transform',
    id: '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/whitelist.js',
    plugin: 'commonjs',
    watchFiles: [
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/packages/SwingSet/src/kernel/vatManager/lockdown-subprocess-xsnap.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/packages/xsnap/lib/bootstrap.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/packages/xsnap/lib/console-shim.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/packages/xsnap/lib/text-shim.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/packages/xsnap/lib/lockdown-shim.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/packages/eventual-send/shim.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/lockdown.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/packages/eventual-send/src/index.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/commons.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/tame-function-tostring.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/intrinsics.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/get-anonymous-intrinsics.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/lockdown-shim.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/compartment-shim.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/error/assert.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/packages/eventual-send/src/track-turns.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/whitelist.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/inert.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/whitelist-intrinsics.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/repair-legacy-accessors.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/tame-function-constructors.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/tame-date-constructor.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/tame-math-object.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/tame-regexp-constructor.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/enable-property-overrides.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/tame-locale-methods.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/global-object.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/evaluate.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/scope-constants.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/transforms.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/error/tame-console.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/error/tame-error-constructor.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/error/stringify-utils.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/error/types.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/error/internal-types.js',
    ],
    message: 'Cannot assign to read only property \'constructor\' of object \'[object Object]\' in /Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/whitelist.js',
  }



  demos › run encouragementBot Demo

  Rejected promise returned by test. Reason:

  TypeError {
    code: 'PLUGIN_ERROR',
    hook: 'transform',
    id: '/Users/markmiller/src/ongithub/agoric/agoric-sdk/node_modules/ses/src/whitelist.js',
    plugin: 'commonjs',
    watchFiles: [
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/packages/SwingSet/src/kernel/vatManager/lockdown-subprocess-xsnap.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/packages/xsnap/lib/bootstrap.js',
      '/Users/markmiller/src/ongithub/agoric/agoric-sdk/packages/xsnap/lib/console-shim.js',

erights · 2021-02-10T00:44:30Z

Fixing Object.prototype.constructor would also remove two of the eight junk lines in the VSCode debugger's object inspector of all objects. This is a significant noise reduction of the debugging experience.

erights · 2021-02-10T00:45:02Z

Sorry closed by mistake

dckc · 2021-02-27T00:31:44Z

with stackFiltering set to verbose in install-ses I get more detail:


@@@@@@2 [TypeError: Cannot assign to read only property 'constructor' of object '[object Object]' in /home/connolly/projects/agoric/SES-shim/packages/ses/src/whitelist.js
  at Object.pp$2.checkLVal (/home/connolly/projects/agoric/agoric-sdk/node_modules/acorn/dist/acorn.js:1814:33)
  at Object.pp$3.checkParams (/home/connolly/projects/agoric/agoric-sdk/node_modules/acorn/dist/acorn.js:2717:12)
  at Object.pp$3.parseFunctionBody (/home/connolly/projects/agoric/agoric-sdk/node_modules/acorn/dist/acorn.js:2685:12)
  at Object.pp$1.parseFunction (/home/connolly/projects/agoric/agoric-sdk/node_modules/acorn/dist/acorn.js:1283:10)
  at Object.pp$1.parseFunctionStatement (/home/connolly/projects/agoric/agoric-sdk/node_modules/acorn/dist/acorn.js:983:17)
  at Object.pp$1.parseStatement (/home/connolly/projects/agoric/agoric-sdk/node_modules/acorn/dist/acorn.js:830:19)
  at Object.parseStatement (/home/connolly/projects/agoric/agoric-sdk/packages/bundle-source/node_modules/rollup/dist/shared/node-entry.js:11825:30)
  at Object.pp$1.parseTopLevel (/home/connolly/projects/agoric/agoric-sdk/node_modules/acorn/dist/acorn.js:746:23)
  at Object.parse (/home/connolly/projects/agoric/agoric-sdk/node_modules/acorn/dist/acorn.js:553:17)
  at InertConstructor.parse (/home/connolly/projects/agoric/agoric-sdk/node_modules/acorn/dist/acorn.js:576:37)
  at Graph.contextParse (/home/connolly/projects/agoric/agoric-sdk/packages/bundle-source/node_modules/rollup/dist/shared/node-entry.js:13216:70)
  at tryParse (/home/connolly/projects/agoric/agoric-sdk/packages/bundle-source/node_modules/@rollup/plugin-commonjs/dist/index.js:282:12)
  at checkEsModule (/home/connolly/projects/agoric/agoric-sdk/packages/bundle-source/node_modules/@rollup/plugin-commonjs/dist/index.js:296:15)
  at Object.transformAndCheckExports (/home/connolly/projects/agoric/agoric-sdk/packages/bundle-source/node_modules/@rollup/plugin-commonjs/dist/index.js:801:28)
  at Object.transform (/home/connolly/projects/agoric/agoric-sdk/packages/bundle-source/node_modules/@rollup/plugin-commonjs/dist/index.js:884:48)
  at /home/connolly/projects/agoric/agoric-sdk/packages/bundle-source/node_modules/rollup/dist/shared/node-entry.js:13113:25] {
  id: '/home/connolly/projects/agoric/SES-shim/packages/ses/src/whitelist.js',
  hook: 'transform',
  code: 'PLUGIN_ERROR',
  plugin: 'commonjs'
}

dckc · 2021-03-01T16:44:29Z

I'm expanding the scope of this to actually getting rid of the console noise; i.e. doing the SES-shim release @erights asked for and upgrading agoric-sdk to use it.

erights · 2021-03-01T16:59:58Z

I'm expanding the scope of this to actually getting rid of the console noise; i.e. doing the SES-shim release @erights asked for and upgrading agoric-sdk to use it.

Excellent, thanks!

If we can get endojs/endo#590 and endojs/endo#591 in quickly enough to make this release, that would be nice. Otherwise they can wait until the next release.

dckc · 2021-03-02T01:18:07Z

#2552 failed lint:types due to outdated @agoric/make-hardener types. I tried to make a release with the types fixed (9b16d93fe94b9) but I don't have write access to https://www.npmjs.com/package/@agoric/make-hardener .

I wouldn't mind keeping it that way :)

@warner perhaps you're willing to move the ball ahead the next few yards? If not, nominate somebody? (if it's me, grant me npm write access)

erights added the bug Something isn't working label Feb 3, 2021

erights mentioned this issue Feb 3, 2021

WIP Stop enabling O.p.constructor endojs/endo#569

Closed

erights assigned warner and dckc Feb 3, 2021

erights closed this as completed Feb 10, 2021

erights reopened this Feb 10, 2021

erights mentioned this issue Feb 10, 2021

Vega (used in stat-logger) overrides O.p.hasOwnProperty by assignment #2373

Closed

dckc changed the title ~~Something in the xsnap integration seems to override O.p.constructor by assignment~~ can't get rid of <[Object: null prototype] {}> console noise due to something in the xsnap / override O.p.constructor Feb 19, 2021

dckc mentioned this issue Feb 27, 2021

fix(bundleSource): patch acorn with defineProperty to avoid override mistake #2549

Merged

erights closed this as completed in #2549 Feb 27, 2021

erights mentioned this issue Feb 28, 2021

Stop enabling O.p.constructor to be overridden by assignment. endojs/endo#587

Merged

dckc reopened this Mar 1, 2021

dckc changed the title ~~can't get rid of <[Object: null prototype] {}> console noise due to something in the xsnap / override O.p.constructor~~ get rid of <[Object: null prototype] {}> console noise Mar 1, 2021

dckc mentioned this issue Mar 2, 2021

fix: upgrade ses to 0.12.3 to avoid console noise #2552

Merged

dckc closed this as completed in #2552 Mar 2, 2021

erights mentioned this issue Mar 4, 2021

Tracking issue for getting 3rd party packages more SES friendly endojs/endo#576

Closed

kriskowal mentioned this issue Feb 6, 2024

Ecosystem Compatibility (2024-02-05 onward) endojs/endo#2037

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

get rid of <[Object: null prototype] {}> console noise #2324

get rid of <[Object: null prototype] {}> console noise #2324

erights commented Feb 3, 2021 •

edited

Loading

erights commented Feb 10, 2021

erights commented Feb 10, 2021

erights commented Feb 10, 2021

dckc commented Feb 27, 2021

dckc commented Mar 1, 2021

erights commented Mar 1, 2021

dckc commented Mar 2, 2021

get rid of <[Object: null prototype] {}> console noise #2324

get rid of <[Object: null prototype] {}> console noise #2324

Comments

erights commented Feb 3, 2021 • edited Loading

erights commented Feb 10, 2021

erights commented Feb 10, 2021

erights commented Feb 10, 2021

dckc commented Feb 27, 2021

dckc commented Mar 1, 2021

erights commented Mar 1, 2021

dckc commented Mar 2, 2021

erights commented Feb 3, 2021 •

edited

Loading