Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecosystem Compatibility (2024-02-05 onward) #2037

Open
kriskowal opened this issue Feb 6, 2024 · 6 comments
Open

Ecosystem Compatibility (2024-02-05 onward) #2037

kriskowal opened this issue Feb 6, 2024 · 6 comments
Labels
ecosystem-compatibility Tracks a compatibility issue in a third-party package or packages. tracking For tracking issues that will never be closed.

Comments

@kriskowal
Copy link
Member

kriskowal commented Feb 6, 2024

Index of ecosystem compatibility notes from 2021-02-10 to 2024-02-05 #1950 with updates to follow in subsequent comments and separate issues with the label ecosystem-compatibility.

@kriskowal kriskowal added tracking For tracking issues that will never be closed. ecosystem-compatibility Tracks a compatibility issue in a third-party package or packages. labels Feb 6, 2024
@kriskowal kriskowal changed the title Ecosystem Compatibility (2021-02-10 – 2024-02-05) Ecosystem Compatibility (2024-02-05 onward) Feb 6, 2024
@gibson042
Copy link
Contributor

TODO: https://github.com/isaacs/minimatch/blob/ef8f2672bdbbf6a632ea815636659fb31b5169aa/src/index.ts#L1012

PR for that is at isaacs/minimatch#228

@kriskowal
Copy link
Member Author

mimic-fn does not compose well with our toString enablements. This manifests as a “Cannot define property with both value and get” (effectively). I have proposed a fix: sindresorhus/mimic-function#51

@ljharb
Copy link

ljharb commented Mar 14, 2024

wouldn't that fix end up setting writable to false when it's a getter, because there's no writable in the first place? or is that fine

@kriskowal
Copy link
Member Author

wouldn't that fix end up setting writable to false when it's a getter, because there's no writable in the first place? or is that fine

That’s a good question for @sindresorhus and the intended outcome for mimic-function. I think mirroring a getter with a non-writable value is possibly consistent with the intent.

@erights
Copy link
Contributor

erights commented Apr 1, 2024

See #2033 (comment)

Should #2033 be tracked here as an endo ecosystem compat issue?

mergify bot added a commit to Agoric/agoric-sdk that referenced this issue Oct 22, 2024
evergreen

## Description
#10303 failed on forwarding the `express` patch. That patch is to work around https://github.com/Agoric/agoric-sdk/discussions/8513 which is still a problem in the latest 4.x of Express:
https://github.com/expressjs/express/blob/4.x/lib/router/index.js#L519

Fortunately, they recently released a v5
https://github.com/expressjs/express/releases/tag/v5.0.0

This bumps the two packages that use `express` to use that latest version.

For the `solo` package, some changes were needed to the path expression, explained in https://expressjs.com/en/guide/migrating-5.html#path-syntax

### Security Considerations
none

### Scaling Considerations
none

### Documentation Considerations
Should the research on v4 vs v5 go in endojs/endo#2037 ? 

### Testing Considerations
CI

### Upgrade Considerations
none, doesn't run on chain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecosystem-compatibility Tracks a compatibility issue in a third-party package or packages. tracking For tracking issues that will never be closed.
Projects
None yet
Development

No branches or pull requests

5 participants