remove crankNumber from transcript #2428
Assignees
Labels
Comments
warner
added a commit
that referenced
this issue
Feb 15, 2021
The VatManager is responsible for maintaining a transcript of all deliveries to their vat worker, so the vat can be reloaded later. These transcript entries have been including the `crankNumber`: a global counter indicating how many cranks have been delivered (to all vats, not just the one for which the transcript entry is being created). This removes that crankNumber from the transcript: * each vat should be independent, this global crankNumber is revealing information about what happens in other vats * #2400 is changing the type of `crankNumber` to a BigInt, which cannot be serialized by the simple `JSON.stringify` used in vatKeeper.js It also removes the now-unnecessary `kernelKeeper` argument from `makeTranscriptManager`, and changes one test that happened to depend upon the presence of the crankNumber field. closes #2428
warner
added a commit
that referenced
this issue
Feb 15, 2021
The VatManager is responsible for maintaining a transcript of all deliveries to their vat worker, so the vat can be reloaded later. These transcript entries have been including the `crankNumber`: a global counter indicating how many cranks have been delivered (to all vats, not just the one for which the transcript entry is being created). This removes that crankNumber from the transcript: * each vat should be independent, this global crankNumber is revealing information about what happens in other vats * #2400 is changing the type of `crankNumber` to a BigInt, which cannot be serialized by the simple `JSON.stringify` used in vatKeeper.js It also removes the now-unnecessary `kernelKeeper` argument from `makeTranscriptManager`, and changes one test that happened to depend upon the presence of the crankNumber field. closes #2428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
src/kernel/vatManager/transcript.jsincludes the currentcrankNumberin each transcript entry. #2400 is trying to change the crank number into a BigInt. The combination causesvatKeeper.js'saddToTranscriptto fail, when it attempts toJSON.stringify()the transcript entry. @katelynsills 's fix was to create an augmented stringification function (namedJSONstringify, without the.) which has a replacer for the BigInt (rendering them as plain digits, just as aNator an integralNumberwould do).I think we don't need (or really want) the
crankNumberin the transcript, it records data that is outside the scope of an individual vat (the kernel-global crank number counts deliveries to all vats, not just this one).So the task is to remove
crankNumberfrom the transcript entry, change the two tests that check for it, and then rebase #2400 on top of the result.The text was updated successfully, but these errors were encountered: