fix: remove crankNumber from transcript entries #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VatManager is responsible for maintaining a transcript of all deliveries to their vat worker, so the vat can be reloaded later. These transcript entries have been including the `crankNumber`: a global counter indicating how many cranks have been delivered (to all vats, not just the one for which the transcript entry is being created). This removes that crankNumber from the transcript: * each vat should be independent, this global crankNumber is revealing information about what happens in other vats * #2400 is changing the type of `crankNumber` to a BigInt, which cannot be serialized by the simple `JSON.stringify` used in vatKeeper.js It also removes the now-unnecessary `kernelKeeper` argument from `makeTranscriptManager`, and changes one test that happened to depend upon the presence of the crankNumber field. closes #2428
FUDCo
approved these changes
Feb 15, 2021
warner
added a commit
that referenced
this pull request
Feb 16, 2021
because #2429 changed transcripts stop including `crankNumber`, which is a Nat (and therefore now a BigInt).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VatManager is responsible for maintaining a transcript of all deliveries
to their vat worker, so the vat can be reloaded later. These transcript
entries have been including the
crankNumber: a global counter indicatinghow many cranks have been delivered (to all vats, not just the one for which
the transcript entry is being created).
This removes that crankNumber from the transcript:
information about what happens in other vats
crankNumberto a BigInt, which cannot beserialized by the simple
JSON.stringifyused in vatKeeper.jsIt also removes the now-unnecessary
kernelKeeperargument frommakeTranscriptManager, and changes one test that happened to depend uponthe presence of the crankNumber field.
closes #2428
cc @katelynsills