Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

production bootstrap vat includes sim-chain tools such as connectFaucet #6687

Closed
2 of 3 tasks
dckc opened this issue Dec 16, 2022 · 4 comments
Closed
2 of 3 tasks

production bootstrap vat includes sim-chain tools such as connectFaucet #6687

dckc opened this issue Dec 16, 2022 · 4 comments
Assignees
@warner
Labels
bug Something isn't working cosmic-swingset package: cosmic-swingset security vaults_triage DO NOT USE
Milestone
Vaults EVP

Comments

@dckc
Copy link
Member

dckc commented Dec 16, 2022 •
edited by warner
Loading

What is the Problem Being Solved?

For pismoA, we used boot-psm.js to avoid some complexity from manifest-driven bootstrap actions. In order to support launching the vaults contracts after bootstrap (#4165), we harmonised it with boot-psm.js (#6568). But in doing so, we regressed w.r.t. #4165, by re-introducing SIM_CHAIN_BOOTSTRAP_MANIFEST including connectFaucet into the production bootstrap vat. These testing tools should not be in the production bootstrap vat.

A noteable exception is mailbox access (#5965), where we plan to control access not by leaving the code out altogether but by not issuing any of the provisionpass tokens required to exercise it.

Description of the Design

Tasks
Beta Give feedback
  1. replace ROLE with 3 bootstrap modules; audit contents #7049
    6 of 6
    automerge:rebase
  2. fix(vats)!: no faucet code (centralSupply) in production #7160
  3. chore: avoid some unnecessary bundling in vaultFactory etc. #7169
    automerge:rebase bypass:integration

Goals:

  • turn bootstrap visualization into a regression test
  • obsolete demoIssuers.js in favor of some coreProposals

see also

Security Considerations

Auditors shouldn't even have to consider connectFaucet when reviewing the production bootstrap.

Test Plan

IOU
@dckc dckc added bug Something isn't working cosmic-swingset package: cosmic-swingset security labels Dec 16, 2022
@dckc dckc self-assigned this Dec 16, 2022
This was referenced Dec 16, 2022
Closed
Draft
@otoole-brendan otoole-brendan added the vaults_triage DO NOT USE label Dec 20, 2022
@dckc dckc changed the title production bootstrap vat includes sim-chain tools such as connectFaucet production bootstrap vat includes AMM, sim-chain tools such as connectFaucet Jan 27, 2023
@dckc
Copy link
Member Author

dckc commented Jan 27, 2023

in discussion of reserve module account with @rowgraus , we were reminded that the whole dance between the AMM, reserve, and vaults needs to have the AMM part cut out.

@ivanlei ivanlei added this to the Vaults RC0 milestone Feb 1, 2023
@dckc
Copy link
Member Author

dckc commented Feb 7, 2023

#6641 includes bootstrap work to make vaults and liquidation work without an AMM. I'm inclined to stand by until we see how that goes before resuming work on this.

@dckc dckc changed the title production bootstrap vat includes AMM, sim-chain tools such as connectFaucet production bootstrap vat includes sim-chain tools such as connectFaucet Feb 8, 2023
This was referenced Feb 22, 2023
Closed
Merged
Closed
@turadg turadg mentioned this issue Mar 4, 2023
Merged
@dckc dckc mentioned this issue Mar 6, 2023
Merged
This was referenced Mar 13, 2023
Closed
Merged
@dckc
Copy link
Member Author

dckc commented Mar 23, 2023 •
edited by ivanlei
Loading

IbcATOM is another demo facility that should go away soonish.

perhaps it belongs in a follow-up to...

analagous to...

Filed as

@ivanlei ivanlei assigned warner and unassigned dckc May 3, 2023
warner added a commit that referenced this issue May 5, 2023
@warner
remove a bunch of faucet/centralSupply stuff
75aee7d 
refs #6687
@warner warner mentioned this issue May 5, 2023
Closed
warner added a commit that referenced this issue May 5, 2023
@warner
remove a bunch of faucet/centralSupply stuff
3ab7cbd 
refs #6687
warner added a commit that referenced this issue May 5, 2023
@warner
remove a bunch of faucet/centralSupply stuff
83448ba 
refs #6687
warner added a commit that referenced this issue May 5, 2023
@warner
fix(vats): remove mintInitialSupply from basic behaviors
42d4818 
basic-behaviors.js included a function named `mintInitialSupply()`,
which (if run) would create the `centralSupply` vat, which can create
an initial supply of IST tokens. We obviously don't enable this in the
production config, but several unit tests and testnet configs need it,
as those environments have no other source of tokens.

To assist with auditing, this commit removes `mintInitialSupply` from
the basic behaviors entirely, so the code won't even be present in
production.

The code was moved to `demoIssuers.js`, which is used by
`sim-behaviors.js`, which is in turn used by the sim-chain and a few
tests.

refs #6687
@dckc
Copy link
Member Author

dckc commented May 6, 2023

mintInitialSupply turns out to be needed to set up IST in the vbank. So we're done here.

@dckc dckc closed this as completed May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warner warner

Labels
bug Something isn't working cosmic-swingset package: cosmic-swingset security vaults_triage DO NOT USE
Projects
None yet
Milestone
Vaults EVP
Development

No branches or pull requests
4 participants
@warner @dckc @ivanlei @otoole-brendan