chore: avoid some unnecessary bundling in vaultFactory etc. #7169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ |
turadg
approved these changes
Mar 15, 2023
| * | ||
| * @type {typeof import('@agoric/ertp').AssetKind.NAT} | ||
| */ | ||
| const NAT = 'nat'; |
There was a problem hiding this comment.
We could move AssetKind to agoric/internal to not duplicate.
There was a problem hiding this comment.
I keep wondering about something like @agoric/ertp/constants, but I'm not inclined to mess with the ERTP package API just now.
In the Java world, I gather it's conventional to provide a -api.jar separate from the main implementation .jar file for things like this. I keep wondering about analogs in the JS world... but I guess the JS norm is to just leave it to tree-shaking tools..
Use static type check and unit tests rather than runtime import to avoid bundling all of ERTP just to get, for example, Stable.symbol.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #6687
Description
binaryVoteCounter.jscontract inbundle-vaultFactory.jsimport { Stable, Staking } from 'tokens.js';.Discovered while auditing bootstrap contents (#6687, #7049).
Scaling Considerations
slightly smaller bundle size:
Testing Considerations
Moved
assertKeywordName(Stable.symbol)and the like from a runtime check to a unit test.