Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Sync Endo versions #4604

Merged
merged 10 commits into from
Feb 21, 2022
Merged

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Feb 18, 2022

closes: #4413

Description

Syncs the versions of endo packages to the latest published versions.
Removes outdated patch files for endo packages
Includes the changes from #4413 (minus patch files) to bring in compatibility with explicit types for @endo/marshal
Remove extraneous eslint global declarations

Testing Considerations

This change is depends on concurrent fixes which finish dapp migrations from -r esm to Node.js native ESM.

@mhofman mhofman added tooling repo-wide infrastructure code-style defensive correctness patterns; readability thru consistency labels Feb 18, 2022
@mhofman mhofman marked this pull request as draft February 18, 2022 21:45
packages/xsnap/src/xsnap.js Outdated Show resolved Hide resolved
@kriskowal kriskowal force-pushed the mhofman/sync-endo-packages-2022-02 branch 7 times, most recently from ce37a76 to 373a6d0 Compare February 20, 2022 05:30
@kriskowal kriskowal force-pushed the mhofman/sync-endo-packages-2022-02 branch from 6aa93e3 to c137fd7 Compare February 20, 2022 06:09
@kriskowal kriskowal marked this pull request as ready for review February 20, 2022 06:13
@kriskowal kriskowal removed the request for review from michaelfig February 20, 2022 11:06
@kriskowal kriskowal marked this pull request as draft February 20, 2022 11:06
@kriskowal kriskowal marked this pull request as ready for review February 21, 2022 04:29
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mhofman
Copy link
Member Author

mhofman commented Feb 21, 2022

I'd like to do a little yarn surgery tomorrow morning to avoid duplicate babel packages (which may be a reason dapp broke?)

@mhofman mhofman force-pushed the mhofman/sync-endo-packages-2022-02 branch from c137fd7 to f97398f Compare February 21, 2022 14:38
@kriskowal
Copy link
Member

I'd like to do a little yarn surgery tomorrow morning to avoid duplicate babel packages (which may be a reason dapp broke?)

This almost certainly contributed, as it would explain why I had to explicitly pre-initialize @agoric/babel-standalone in a couple places. It doesn’t account for the problem with @babel/types not having a default export when run under -r esm, which is a dependency we brought in via @endo/static-module-record depending on recast depending on @babel/types.

@kriskowal kriskowal merged commit 781f8a2 into master Feb 21, 2022
@kriskowal kriskowal deleted the mhofman/sync-endo-packages-2022-02 branch February 21, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-style defensive correctness patterns; readability thru consistency tooling repo-wide infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants