fix(cosmos): don't rerun store migrations on upgrade #9683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a3p test for double upgrade running here: https://github.com/Agoric/agoric-sdk/actions/runs/9879460376/job/27285749237 using branch mhofman/9682-test-double-upgrade |
gibson042
approved these changes
Jul 10, 2024
|
Both sets of a3p tests have passed, and we confirmed that this change fixes the problem on emerynet validators. |
mhofman
added a commit
that referenced
this pull request
Jul 10, 2024
## Packages that have NEWS.md updates ```diff --- a/golang/cosmos/CHANGELOG.md +++ b/golang/cosmos/CHANGELOG.md @@ -3,6 +3,15 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.35.0-u16.2](https://github.com/Agoric/agoric-sdk/compare/@agoric/cosmos@0.35.0-u16.1...@agoric/cosmos@0.35.0-u16.2) (2024-07-10) + + +### Bug Fixes + +* **cosmos:** don't rerun store migrations on upgrade ([#9683](#9683)) ([12b78e3](12b78e3)), closes [#9682](#9682) + + + ## [0.35.0-u16.1](https://github.com/Agoric/agoric-sdk/compare/@agoric/cosmos@0.35.0-u16.0...@agoric/cosmos@0.35.0-u16.1) (2024-07-10) **Note:** Version bump only for package @agoric/cosmos ```
mergify bot
added a commit
that referenced
this pull request
Aug 31, 2024
closes: #9682 ## Description Ports the change from #9683 to master, adding some extra checks since master has a more complex upgrade name structure. Update some docs following the refactor in #9575 ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations None ### Testing Considerations This PR originally added an a3p-integration test, but it cannot work without modification to the agd binary just for the purpose of testing this (if the original binary already contains support for the upgrade name, it attempts an upgrade in place, which fails as we don't intend to support this) ### Upgrade Considerations Ensure we have the ability to release and apply multiple release candidates for the same version.
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9682
Description
Add logic to check if the upgrade plan name is a "primary name", and only run store migrations for those.
Check in the upgrade handler that the first upgrade is using a primary name to ensure store migrations were run.
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
a3p test for primary upgrade will run on this PR
mhofman/9682-test-double-upgrade tests applying primary followed by secondary upgrade
Upgrade Considerations
Fixes cosmos store upgrade logic during chain software upgrades