feat: make software upgrade coreProposals conditional on upgrade plan name

[michaelfig]

closes: #9571

Description

Parametrize the price feed core proposals by the upgrade handler name. The proposal for a3p remains with the deprecated ambient (from environment) oracle addresses.

Additionally fix and add some logging to the upgrade vault proposal

Security Considerations

None

Scaling Considerations

Not a typical scaling consideration, but this introduces a "basic" upgrade name that skips all vaults related proposals. The correctly parametrized info can be provided in the chain software upgrade proposal's upgrade info for any chain that has different configuration.

Documentation Considerations

Need to communicate to validators that the pattern of upgrade names has changed.

Testing Considerations

A3P and manually tested on mainfork

Upgrade Considerations

See above

[cloudflare-workers-and-pages]

Deploying agoric-sdk with    Cloudflare Pages

Latest commit:	ea568a2
Status:	✅  Deploy successful!
Preview URL:	https://6870a5d8.agoric-sdk.pages.dev
Branch Preview URL:	https://mfig-cond-software-upgrade.agoric-sdk.pages.dev

View logs

[mhofman]

Suggested change

	"agoric19d6gnr9fyp6hev4tlrg87zjrzsd5gzr5qlfq2p01", // Stakin
	"agoric19uscwxdac6cf6z7d5e26e0jm0lgwstc47cpll8", // node
	"agoric19d6gnr9fyp6hev4tlrg87zjrzsd5gzr5qlfq2p", // Stakin
	"agoric19uscwxdac6cf6z7d5e26e0jm0lgwstc47cpll8", // 01node

[michaelfig]

Awk!

[mhofman]

Suggested change

	"agoric1qj07c7vfk3knqdral0sej7fa6eavkdn8vd8etf01", // Simply Staking
	"agoric1ra0g6crtsy6r3qnpu7ruvm7qd4wjnznyzg5nu4", // node
	"agoric1qj07c7vfk3knqdral0sej7fa6eavkdn8vd8etf", // Simply Staking
	"agoric1ra0g6crtsy6r3qnpu7ruvm7qd4wjnznyzg5nu4", // 01node

[michaelfig]

And again!

[Chris-Hibbert]

javascript changes LGTM. I have no opinion on the go code.

[mhofman]

Nice, can we also panic if expectedUpgradeName doesn't exist in upgradeNamesOfThisVersion, it's so easy to fat finger these names without enum typing

Addressed

[mhofman]

FYI I'm investigating why this is failing on mainfork, holding approval until then

[anilhelvaci]

What is the reason for waiting for a quote when upgrading vaultFactory? @mhofman @Chris-Hibbert

My guess is that in vaultDirector's makePriceLockWaker;

agoric-sdk/packages/inter-protocol/src/vaultFactory/vaultDirector.js

Lines 447 to 450 in ac88da5

	makePriceLockWaker() {
	return makeWaker('priceLockWaker', () => {
	allManagersDo(vm => vm.lockOraclePrices());
	});

allManagersDo iterates over all vault managers to invoke their lockOraclePrices sequentially. If there's a case such as no price updates are pushed for a certain vault manager when priceLockWaker is awake, then lockOraclePrices for that certain vault manager will fail. Which will result with vault managers added later than the failing one will not be able to lock their prices because allManagersDo invokes lockOraclePrices sequentially, see:

agoric-sdk/packages/inter-protocol/src/vaultFactory/vaultDirector.js

Lines 267 to 273 in ac88da5

	const allManagersDo = fn => {
	for (const managerIndex of collateralManagers.values()) {
	const vm = vaultManagers.get(managerIndex).self;
	fn(vm);
	}
	};

I have already opened an issue about this, please see #9706. In the issue I have a possible fix which worked for me quite nicely.

However, I am very curios to find out what other reasons there may be for waiting a price feed update before upgrading vaultFactory?

[Chris-Hibbert]

What is the reason for waiting for a quote when upgrading vaultFactory? @mhofman @Chris-Hibbert

When we run the coreEval to do the upgrade, we'll be upgrading vaultFactory, and replacing auctions, as well as replacing all the priceAuthorities. After replacing the priceAuthorities, the oracle operators have to manually intervene in order to accept new invitations, and do some reconfiguration in order to start feeding information to the new priceAuthorities. I don't have any indication of whether that will take a half hour or a couple of days.

During the interim, it's best that the vaults and auctions continue to listen to the old priceAuthorities. The indication that the switchover is complete is that any price starts coming via the new priceAuthorities. At that point, we upgrade the vaultFactory, which will then start paying attention to the new priceAuthorities.

[anilhelvaci]

Thanks Chris!