merge with master #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Description of changes The tests for each individual setup step component have a lot of redundant setup code for preparing stubs of the common props, so this adds an `AndroidSetupStepPropsBuilder` class to hide reasonable default stub implementations such that we don't have to modify every step's test classes every time we add a new common prop. (this would have prevented the merge conflict that broke master 20min ago, and fixes the same) #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: #0000 - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a] (UI changes only) Verified usability with NVDA/JAWS
Currently, the info and examples grids do not properly reflow when zoom is at 400%. This PR causes them to properly reflow at that zoom.
* feat(android-setup): Add detect-adb step to the state machine - Add configuration for the detect-adb state machine step - Remove 'close' from AndroidSetupActions because an action to close the app exists elsewhere - Rework createAndroidSetupSteps into createStateMachineSteps so the logic could be tested independent of the types - Remove unit tests for allAndroidSetupSteps because it is essentially a data table - Add unit tests for createStateMachineSteps to ensure the steps in allAndroidSetupSteps will be created as expected - Add detectAdb function to AndroidSetupDeps - if adb path is detected, the return value will be true; otherwise, false - Rename android-setup-steps-factory.ts to android-setup-steps-configs.ts - Modify StateMachineStep.onEnter to be asynchronous - onEnter is designed to run background tasks such as detecting connected devices. Allowing such tasks to run asynchronously allows us to present UI such as wait spinners * feat(android-setup): Fix async onEnter state machine tests * feat(android-setup): Fix broken AndroidSetupStore broken unit tests * Fix linting error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.