Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write regression test for soft deletes bug #170

Closed
hackaugusto opened this issue Feb 22, 2021 · 0 comments · Fixed by #873
Closed

Write regression test for soft deletes bug #170

hackaugusto opened this issue Feb 22, 2021 · 0 comments · Fixed by #873
Labels
good first issue Good for newcomers test Test related issue

Comments

@hackaugusto
Copy link
Contributor

PR fixing the issue: #169

Previously Karapace would ignore soft deleted schemas (schemas with deleted flag set) if the schemas was not seen before. This was a problem since the _shemas topic is log.cleanup.policy=compact, and Karapace would only see the deleted schema. That meant the schema would not be available through the schemas/ids/:id which broke some use cases.
@hackaugusto hackaugusto added the good first issue Good for newcomers label Apr 15, 2021
@hackaugusto hackaugusto added the test Test related issue label Jul 12, 2021
jjaakola-aiven added a commit that referenced this issue May 13, 2024
@jjaakola-aiven
test: store soft deleted schema
b639729 
When _schemas topic has been compacted and only soft deleted version
of the schema is present the schema must be stored in the in memory
database.
Fixes #170.
@jjaakola-aiven jjaakola-aiven mentioned this issue May 13, 2024
Merged
jjaakola-aiven added a commit that referenced this issue May 15, 2024
@jjaakola-aiven
test: store soft deleted schema
d1bba10 
When _schemas topic has been compacted and only soft deleted version
of the schema is present the schema must be stored in the in memory
database.
Fixes #170.
jjaakola-aiven added a commit that referenced this issue Jun 6, 2024
@jjaakola-aiven
test: store soft deleted schema
4135724 
When _schemas topic has been compacted and only soft deleted version
of the schema is present the schema must be stored in the in memory
database.
Fixes #170.
jjaakola-aiven added a commit that referenced this issue Jun 7, 2024
@jjaakola-aiven
test: store soft deleted schema
98b6ef6 
When _schemas topic has been compacted and only soft deleted version
of the schema is present the schema must be stored in the in memory
database.
Fixes #170.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers test Test related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: store soft deleted schema Aiven-Open/karapace
1 participant
@hackaugusto