Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: store soft deleted schema #873

Conversation

jjaakola-aiven
Copy link
Contributor

About this change - What it does

When _schemas topic has been compacted and only soft deleted version of the schema is present the schema must be stored in the in memory database.

Fixes #170.

@jjaakola-aiven jjaakola-aiven requested review from a team as code owners May 13, 2024 12:12
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-test-soft-deleted-schema-is-stored-when-topic-compacted branch from b639729 to d1bba10 Compare May 15, 2024 07:05
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-test-soft-deleted-schema-is-stored-when-topic-compacted branch from d1bba10 to 4135724 Compare June 6, 2024 10:40
keejon
keejon previously approved these changes Jun 7, 2024
Copy link
Contributor

@keejon keejon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@keejon
Copy link
Contributor

keejon commented Jun 7, 2024

@jjaakola-aiven some conflicts have to be resolved first

When _schemas topic has been compacted and only soft deleted version
of the schema is present the schema must be stored in the in memory
database.
Fixes #170.
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-test-soft-deleted-schema-is-stored-when-topic-compacted branch from 4135724 to 98b6ef6 Compare June 7, 2024 13:10
@keejon keejon enabled auto-merge June 7, 2024 13:13
@keejon keejon merged commit b5c9d22 into main Jun 7, 2024
8 checks passed
@keejon keejon deleted the jjaakola-aiven-test-soft-deleted-schema-is-stored-when-topic-compacted branch June 7, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write regression test for soft deletes bug
2 participants