Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icons: update to support new design tokens #211

Closed
blackfalcon opened this issue Oct 4, 2023 · 1 comment · Fixed by #212 or #216
Closed

icons: update to support new design tokens #211

blackfalcon opened this issue Oct 4, 2023 · 1 comment · Fixed by #212 or #216
Assignees
@blackfalcon
Labels
icons Type: Feature New Feature

Comments

@blackfalcon
Copy link
Member

Is your feature request related to a problem? Please describe.

The following code is restricted to only support the legacy Auro design tokens

Icons/src/data/icons.json

Lines 8 to 9 in 299db99

"width": "var(--auro-size-lg)",
"height": "var(--auro-size-lg)",

Describe the solution you'd like

Update token references to use new naming convention

Describe alternatives you've considered

none

Additional context

none

Exit criteria

This issue can be closed once the icon build supports the new token names.
@blackfalcon blackfalcon added Type: Feature New Feature icons not-reviewed Issue has not been reviewed by Auro team members labels Oct 4, 2023
@blackfalcon blackfalcon self-assigned this Oct 4, 2023
@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team members label Oct 4, 2023
blackfalcon added a commit that referenced this issue Oct 4, 2023
@blackfalcon
perf: update icon size token ref #211
6bcf1e1 
This commit updates the icons to use the new -ds token name
specification.

Changes to be committed:
modified:   src/data/icons.json
@blackfalcon blackfalcon mentioned this issue Oct 4, 2023
Merged
6 tasks
@blackfalcon blackfalcon linked a pull request Oct 4, 2023 that will close this issue
Update icon size token ref #212
Merged
6 tasks
blackfalcon added a commit that referenced this issue Oct 4, 2023
@blackfalcon
perf: update icon size token ref #211
aff857d 
This commit updates the icons to use the new -ds token name
specification.

Changes to be committed:
modified:   src/data/icons.json

This commit also updated the icon demo page to also support the latest
version of the Auro Design Tokens.

Changes to be committed:
modified:   scripts/buildDemo.js
blackfalcon added a commit that referenced this issue Oct 10, 2023
@blackfalcon
perf: update icon size token ref #211
c55579f 
This commit updates the icons to use the new -ds token name
specification.

Changes to be committed:
modified:   src/data/icons.json

This commit also updated the icon demo page to also support the latest
version of the Auro Design Tokens.

Changes to be committed:
modified:   scripts/buildDemo.js
AuroDesignSystem pushed a commit that referenced this issue Oct 10, 2023
@semantic-release-bot
chore(release): 4.28.1 [skip ci]
a9bd74b 
## [4.28.1](v4.28.0...v4.28.1) (2023-10-10)

### Performance Improvements

* update icon size token ref [#211](#211) ([c55579f](c55579f))
blackfalcon added a commit that referenced this issue Oct 10, 2023
@blackfalcon
fix: revert commit from CSS change #211
7df5824 
This commit reverts commit c55579f that changed the CSS token reference
in the SVG. This had an unforeseen side effect on auro-icon's custom
size feature.

Changes to be committed:
modified:   src/data/icons.json
AuroDesignSystem pushed a commit that referenced this issue Oct 10, 2023
@semantic-release-bot
chore(release): 4.28.2 [skip ci]
adc87f1 
## [4.28.2](v4.28.1...v4.28.2) (2023-10-10)

### Bug Fixes

* revert commit from CSS change [#211](#211) ([7df5824](7df5824))
@blackfalcon blackfalcon mentioned this issue Oct 10, 2023
Closed
@blackfalcon
Copy link
Member Author

This issue has been brought back as there was a need to revert the commit that changed the in-line CSS in the icons.

@blackfalcon blackfalcon reopened this Oct 10, 2023
@blackfalcon blackfalcon mentioned this issue Oct 10, 2023
Merged
6 tasks
blackfalcon added a commit that referenced this issue Oct 11, 2023
@blackfalcon
perf: update SVGs to support new token name spec #211
688c3d3 
This commit reverts the revert for using the new Auro design token name
spec. The revert happened due to a side-effect with auro-icon and the
customSize feature. The auro-icon element was updated to allow for more
flexibility in token use.

See AlaskaAirlines/auro-icon#95

This update has been verified that regardless of version of tokens a
consumer has installed, or none at all, the customSize feature will work
as expected.

Changes to be committed:
modified:   src/data/icons.json
@blackfalcon blackfalcon mentioned this issue Oct 11, 2023
Merged
6 tasks
@blackfalcon blackfalcon linked a pull request Oct 11, 2023 that will close this issue
perf: update SVGs to support new token name spec #211 #216
Merged
6 tasks
blackfalcon added a commit that referenced this issue Oct 12, 2023
@blackfalcon
perf: update SVGs to support new token name spec #211
db8fb2f 
This commit reverts the revert for using the new Auro design token name
spec. The revert happened due to a side-effect with auro-icon and the
customSize feature. The auro-icon element was updated to allow for more
flexibility in token use.

See AlaskaAirlines/auro-icon#95

This update has been verified that regardless of version of tokens a
consumer has installed, or none at all, the customSize feature will work
as expected.

Changes to be committed:
modified:   src/data/icons.json
blackfalcon added a commit that referenced this issue Oct 12, 2023
@blackfalcon
perf: update SVGs to support new token name spec #211
7f364a6 
This commit reverts the revert for using the new Auro design token name
spec. The revert happened due to a side-effect with auro-icon and the
customSize feature. The auro-icon element was updated to allow for more
flexibility in token use.

See AlaskaAirlines/auro-icon#95

This update includes a solution that applies a variable with a variable
fallback with a hard value fallback. The --auro token was specifically
listed first as this is an order of expectation from in-the-wild auro
elements using the legacy --auro token.

It has been verified that regardless of version of tokens a
consumer has installed, or none at all, the customSize feature will work
as expected.

Changes to be committed:
modified:   src/_icons.scss
modified:   src/data/icons.json
blackfalcon added a commit that referenced this issue Oct 12, 2023
@blackfalcon
perf: update SVGs to support new token name spec #211
c83c9ad 
This commit reverts the revert for using the new Auro design token name
spec. The revert happened due to a side-effect with auro-icon and the
customSize feature. The auro-icon element was updated to allow for more
flexibility in token use.

See AlaskaAirlines/auro-icon#95

This update includes a solution that applies a variable with a variable
fallback with a hard value fallback. The --auro token was specifically
listed first as this is an order of expectation from in-the-wild auro
elements using the legacy --auro token.

It has been verified that regardless of version of tokens a
consumer has installed, or none at all, the customSize feature will work
as expected.

Changes to be committed:
modified:   src/_icons.scss
modified:   src/data/icons.json
blackfalcon added a commit that referenced this issue Oct 12, 2023
@blackfalcon
perf: update SVGs to support new token name spec #211
e737da2 
This commit reverts the revert for using the new Auro design token name
spec. The revert happened due to a side-effect with auro-icon and the
customSize feature. The auro-icon element was updated to allow for more
flexibility in token use.

See AlaskaAirlines/auro-icon#95

This update includes a solution that applies a variable with a variable
fallback with a hard value fallback. The --auro token was specifically
listed first as this is an order of expectation from in-the-wild auro
elements using the legacy --auro token.

It has been verified that regardless of version of tokens a
consumer has installed, or none at all, the customSize feature will work
as expected.

Changes to be committed:
modified:   src/_icons.scss
modified:   src/data/icons.json
AuroDesignSystem pushed a commit that referenced this issue Oct 12, 2023
@semantic-release-bot
chore(release): 4.29.1 [skip ci]
2183390 
## [4.29.1](v4.29.0...v4.29.1) (2023-10-12)

### Performance Improvements

* update SVGs to support new token name spec [#211](#211) ([e737da2](e737da2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

Labels
icons Type: Feature New Feature
Projects
None yet
Milestone
No milestone
1 participant
@blackfalcon