Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-icon: support new WCSS and auro design tokens #94

Closed
blackfalcon opened this issue Oct 10, 2023 · 1 comment · Fixed by #95
Closed

auro-icon: support new WCSS and auro design tokens #94

blackfalcon opened this issue Oct 10, 2023 · 1 comment · Fixed by #95
Assignees
@blackfalcon
Labels
auro-icon Type: Feature New Feature

Comments

@blackfalcon
Copy link
Member

Is your feature request related to a problem? Please describe.

A new MAJOR release of WCSS and auro design tokens have been released and this repo needs to support the new specs.

Describe the solution you'd like

Update all the dependencies and Sass per these changes.

Describe alternatives you've considered

None

Additional context

Also be aware that there is a compound issue with supporting auro-icon.

A recent update had to be rolled back due to a conflict with the custom sizing feature had the released changed. This will also need to be addressed.

Exit criteria

This issue can be closed once the dependencies and related code has been updated and there is a solution that will support the auro icons update to the SVGs too.
@blackfalcon blackfalcon self-assigned this Oct 10, 2023
This was referenced Oct 10, 2023
Closed
Merged
blackfalcon added a commit that referenced this issue Oct 11, 2023
@blackfalcon
feat: upgrade to supoprt new Auro design tokens #94
8d1aae1 
This commit updates all the token references to support the new design
token naming spec. All CSS also supports fallback values to ensure
smooth transition from legacy to new.

TODO: There are 2 to-dos in this commit. Once there is an assumption
that most teams have transitioned to the new token spec, the code that
these to-dos are referencing can be removed as well as any npm package
or reference to the legacy tokens.

Changes to be committed:
modified:   package-lock.json
modified:   package.json
modified:   src/alaskaStyle.scss
modified:   src/iconStyle.scss
modified:   src/style.scss
@blackfalcon blackfalcon mentioned this issue Oct 11, 2023
Merged
6 tasks
@blackfalcon blackfalcon linked a pull request Oct 11, 2023 that will close this issue
Upgrade to supoprt new Auro design tokens #94 #95
Merged
6 tasks
blackfalcon added a commit that referenced this issue Oct 11, 2023
@blackfalcon
feat: upgrade to supoprt new Auro design tokens #94
37913ff 
This commit updates all the token references to support the new design
token naming spec. All CSS also supports fallback values to ensure
smooth transition from legacy to new.

TODO: There are 2 to-dos in this commit. Once there is an assumption
that most teams have transitioned to the new token spec, the code that
these to-dos are referencing can be removed as well as any npm package
or reference to the legacy tokens.

Changes to be committed:
modified:   demo/index.html
modified:   package-lock.json
modified:   package.json
modified:   src/alaskaStyle.scss
modified:   src/iconStyle.scss
modified:   src/style.scss
blackfalcon added a commit that referenced this issue Oct 12, 2023
@blackfalcon
feat: upgrade to supoprt new Auro design tokens #94
6a05aa1 
This commit updates all the token references to support the new design
token naming spec. All CSS also supports fallback values to ensure
smooth transition from legacy to new.

TODO: There are 2 to-dos in this commit. Once there is an assumption
that most teams have transitioned to the new token spec, the code that
these to-dos are referencing can be removed as well as any npm package
or reference to the legacy tokens.

Changes to be committed:
modified:   demo/index.html
modified:   package-lock.json
modified:   package.json
modified:   src/alaskaStyle.scss
modified:   src/iconStyle.scss
modified:   src/style.scss
blackfalcon added a commit that referenced this issue Oct 12, 2023
@blackfalcon
feat: upgrade to supoprt new Auro design tokens #94
4ddb85f 
This commit updates all the token references to support the new design
token naming spec. All CSS also supports fallback values to ensure
smooth transition from legacy to new.

TODO: There are 2 to-dos in this commit. Once there is an assumption
that most teams have transitioned to the new token spec, the code that
these to-dos are referencing can be removed as well as any npm package
or reference to the legacy tokens.

Changes to be committed:
modified:   demo/index.html
modified:   package-lock.json
modified:   package.json
modified:   src/alaskaStyle.scss
modified:   src/iconStyle.scss
modified:   src/style.scss
@irma-kurnia-phtn irma-kurnia-phtn mentioned this issue Oct 24, 2023
Closed
@blackfalcon
Copy link
Member Author

Adding scope to this PR. The following line of code needs to be updated to support https://cdn.jsdelivr.net/npm/ versus unpkg which is proving to be more unreliable.

Updated exit criteria

This issue can be closed once the legacy reference to unpkg is updated to support jsdelivr.

blackfalcon added a commit that referenced this issue Oct 30, 2023
@blackfalcon
feat: upgrade to supoprt new Auro design tokens #94
16b3e34 
This commit updates all the token references to support the new design
token naming spec. All CSS also supports fallback values to ensure
smooth transition from legacy to new.

TODO: There are 2 to-dos in this commit. Once there is an assumption
that most teams have transitioned to the new token spec, the code that
these to-dos are referencing can be removed as well as any npm package
or reference to the legacy tokens.

Changes to be committed:
modified:   demo/index.html
modified:   package-lock.json
modified:   package.json
modified:   src/alaskaStyle.scss
modified:   src/iconStyle.scss
modified:   src/style.scss
blackfalcon pushed a commit that referenced this issue Oct 30, 2023
@semantic-release-bot
chore(release): 4.1.0 [skip ci]
c00dfea 
# [4.1.0](v4.0.2...v4.1.0) (2023-10-30)

### Features

* upgrade to supoprt new Auro design tokens [#94](#94) ([16b3e34](16b3e34))

### Performance Improvements

* add types to build script ([8d3151f](8d3151f))
* remove legacy token dependnecy ([5baa678](5baa678))
* update default URI reference ([16d5634](16d5634))
* update dependencies ([3407545](3407545))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

Labels
auro-icon Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to supoprt new Auro design tokens #94 AlaskaAirlines/auro-icon
2 participants
@blackfalcon @Patrick-Daly-AA