Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement color theming support #198

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Aug 23, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #197

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

  • Implement color theming support with the new set of design tokens
  • Update dependencies
  • Remove deprecated code as this is the next major release

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Implement color theming support with new design tokens, refactor breakpoints, update color variables, and remove deprecated code for the upcoming major release.

New Features:

  • Introduce color theming support using a new set of design tokens, allowing for more flexible and consistent styling across the application.

Enhancements:

  • Refactor breakpoints to use a more flexible mixin approach, replacing deprecated breakpoint mixins with a new auro_breakpoint mixin.
  • Update various color variables to align with the new design tokens, improving consistency in color usage across components.

Documentation:

  • Update documentation to reflect the removal of deprecated code and the introduction of new theming capabilities.

Tests:

  • Adjust tests to accommodate changes in color values and breakpoint mixins, ensuring compatibility with the new theming system.

Chores:

  • Remove deprecated code in preparation for the next major release, streamlining the codebase and reducing technical debt.

@jordanjones243 jordanjones243 self-assigned this Aug 23, 2024
@jordanjones243 jordanjones243 requested a review from a team as a code owner August 23, 2024 20:43
@CLAassistant
Copy link

CLAassistant commented Aug 23, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ jordanjones243
✅ blackfalcon
❌ semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

@jordanjones243 jordanjones243 linked an issue Aug 23, 2024 that may be closed by this pull request
Copy link

sourcery-ai bot commented Aug 23, 2024

Reviewer's Guide by Sourcery

This pull request implements color theming support with a new set of design tokens, updates dependencies, and removes deprecated code as part of the next major release. The changes primarily involve updating color variables and breakpoint mixins throughout the codebase.

File-Level Changes

Change Details Files
Updated color variables to use new design tokens
  • Replaced old color variables with new design token variables
  • Updated background colors, text colors, and border colors
  • Modified hover and active state colors
src/_essentials.scss
src/_blockquote.scss
src/_focus-visible.scss
src/elementDemoStyles/elementDemoStyles.scss
src/componentSupport/_table.scss
src/utilityMixins/_anchor-roleButton.scss
src/utilityMixins/_anchor-roleTab.scss
Refactored breakpoint mixins
  • Removed deprecated breakpoint mixins (auro_breakpoint--sm, auro_breakpoint--md, auro_breakpoint--lg)
  • Updated usage of breakpoint mixins to use the new auro_breakpoint mixin with explicit parameters
src/_breakpoints.scss
src/_headings.scss
src/componentSupport/_containedButtons.scss
src/componentSupport/_table.scss
src/componentSupport/_tablist.scss
Removed deprecated code
  • Removed deprecated global selector styles
  • Deleted deprecated grid class
src/_core.scss
src/_grids.scss
Updated dependencies and version number
  • Incremented version number to 5.1.2
  • Updated changelog with new version information
docs/index.html
CHANGELOG.md

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jordanjones243 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider providing a migration guide or documentation to help users update to the new color token system and removed features.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@jason-capsule42 jason-capsule42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good except the one pink token. Change that and then "approved" for release.

src/elementDemoStyles/elementDemoStyles.scss Outdated Show resolved Hide resolved
@jordanjones243 jordanjones243 changed the base branch from beta to master August 26, 2024 17:30
@jordanjones243 jordanjones243 changed the base branch from master to beta August 26, 2024 17:30
BREAKING CHANGE: all previously deprecated code has been removed and will no longer be supported
@jordanjones243 jordanjones243 force-pushed the jjones/colorTheming/#197 branch from aa87c72 to d49f11b Compare August 26, 2024 17:35
@jordanjones243 jordanjones243 changed the base branch from beta to master August 26, 2024 17:37
@jordanjones243 jordanjones243 changed the base branch from master to beta August 26, 2024 17:37
@jordanjones243 jordanjones243 merged commit 14c9791 into beta Aug 26, 2024
3 of 4 checks passed
@jordanjones243 jordanjones243 deleted the jjones/colorTheming/#197 branch August 26, 2024 17:37
@blackfalcon
Copy link
Member

🎉 This PR is included in version 6.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auro-wcss: update for latest design tokens refactor
4 participants