-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MULTI-GITTER PR: migration github-config-and-gitignore-changes #370
MULTI-GITTER PR: migration github-config-and-gitignore-changes #370
Conversation
…thub workflow files
Reviewer's Guide by SourceryThis PR updates various GitHub configuration files and templates to improve the contribution process and repository management. The changes include updates to issue templates, workflow configurations, and documentation files to align with current best practices and requirements. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rmenner - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you explain the reasoning behind removing the demo files (api.md, api.min.js, index.md, index.min.js)? This seems unrelated to the documentation updates and may impact functionality.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Surge demo deployment failed! 😭 |
🎉 This PR is included in version 4.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary by Sourcery
Update GitHub configuration files to improve contribution guidelines, issue templates, and CI workflows. Add a new workflow for demo deployment and enhance documentation for clarity.
CI:
Deployment:
Documentation: