Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AURO MIGRATION: Update node to v22 #371

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Dec 20, 2024

Resolves AlaskaAirlines/auro-templates#6

Summary by Sourcery

Update Node to v22 and revise contributing guidelines.

Build:

  • Update Node to v22.

CI:

  • Update CI to test against Node v20 and v22.

Documentation:

  • Revise contributing guidelines, including updating issue and pull request templates, adding a rebase policy, clarifying commit message guidelines, and updating the code of conduct.

Tests:

  • Update CI tests to Node v20 and v22.

@jason-capsule42 jason-capsule42 requested a review from a team as a code owner December 20, 2024 20:44
@jason-capsule42 jason-capsule42 self-assigned this Dec 20, 2024
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This pull request updates the Auro project to use Node.js v22 and introduces several improvements to the contributing guidelines, issue templates, and CI/CD pipeline.

State diagram: Updated PR workflow states

stateDiagram-v2
    [*] --> IssueSubmitted
    IssueSubmitted --> UnderReview: Team reviews within 48h
    UnderReview --> Abandoned: Author unresponsive
    UnderReview --> Consultation: Team consultation
    Consultation --> Development: Approved to start work
    Development --> PullRequest: Submit PR
    PullRequest --> CodeReview: Team reviews
    CodeReview --> Merged: Approved
    CodeReview --> UpdateRequired: Changes needed
    UpdateRequired --> CodeReview: Updates submitted
    Merged --> [*]
    Abandoned --> [*]
Loading

File-Level Changes

Change Details Files
Updated Node.js version
  • Updated Node.js version to v22 in the test and publish workflow.
  • Updated the engines section in package.json to reflect the new Node.js version.
  • Regenerated package-lock.json to include updated dependencies for Node.js v22.
  • Updated the test matrix in the settings.yml file to use Node.js v20 and v22.
.github/workflows/testPublish.yml
package.json
package-lock.json
.github/settings.yml
Improved contributing guidelines
  • Added a link to the Innersourcing Flow Guide on Sharepoint for Alaska Airlines employees.
  • Clarified the process for submitting issues and pull requests.
  • Added a section on rebasing and why it's preferred over merging.
  • Emphasized the importance of using conventional commits and provided examples.
  • Added a section on Git commit messages and best practices.
.github/CONTRIBUTING.md
Updated issue templates
  • Added exit criteria to all issue templates.
  • Updated the bug report template to request screenshots and clarify content.
  • Updated labels in the issue templates to use double quotes.
.github/ISSUE_TEMPLATE/bug_report.yml
.github/ISSUE_TEMPLATE/feature_request.yml
.github/ISSUE_TEMPLATE/general-support.yml
Added a new workflow to publish a demo
  • Created a new workflow file to publish a demo upon pull request merge to the main branch.
  • The workflow uses a reusable workflow from the AlaskaAirlines/auro-library repository.
  • The workflow uses the AURO_SURGE_TOKEN secret to authenticate with Surge.
.github/workflows/publishDemo.yml
Updated CODEOWNERS file
  • Updated the CODEOWNERS file to reflect changes in team responsibilities. Specific details of the changes were not provided in the diff.
.github/CODEOWNERS
Updated other files
  • Updated the settings.yml file to include team permissions and update status checks.
  • Updated the stale.yml file to include additional configuration options.
  • Updated the pull request template to clarify the summary section and remove an unnecessary option.
  • Updated the code of conduct file to remove specific contact information.
  • Updated the codeql.yml file to remove unused queries.
.github/settings.yml
.github/stale.yml
.github/PULL_REQUEST_TEMPLATE.md
.github/CODE_OF_CONDUCT.md
.github/workflows/codeql.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

github-actions bot commented Dec 20, 2024

Surge demo deployment failed! 😭

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@rmenner rmenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to merge #370

@jason-capsule42 jason-capsule42 force-pushed the migration/package-update/node-v22 branch from 81e1bc0 to 6a04b9e Compare December 22, 2024 19:05
@jason-capsule42 jason-capsule42 merged commit 252d4b1 into main Dec 22, 2024
6 of 7 checks passed
@jason-capsule42 jason-capsule42 deleted the migration/package-update/node-v22 branch December 22, 2024 19:06
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update defined node versions for latest security requirements
3 participants