Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-radio: properties need default value and to be reflected #33

Closed
geoffrich opened this issue May 25, 2021 · 1 comment · Fixed by #51
Closed

auro-radio: properties need default value and to be reflected #33

geoffrich opened this issue May 25, 2021 · 1 comment · Fixed by #51
Assignees
@blackfalcon @geoffrich
Labels
released Completed work has been released Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes

Comments

@geoffrich
Copy link
Contributor

Describe the bug

The following properties are used for styling and need to be reflected:

Radio group:

  • error
  • disabled

In addition, the above properties as well as auro-radio's required need default values so that Svelte apps can use the boolean attribute shorthand.

Expected behavior

See above.
@geoffrich geoffrich added the Type: Bug Bug or Bug fixes label May 25, 2021
@geoffrich geoffrich self-assigned this May 25, 2021
@blackfalcon blackfalcon removed their assignment May 27, 2021
@blackfalcon blackfalcon mentioned this issue Jun 11, 2021
Closed
1 task
@blackfalcon blackfalcon self-assigned this Jun 23, 2021
@geoffrich geoffrich self-assigned this Aug 16, 2021
@geoffrich geoffrich added the Status: Work In Progress Issue or Pull Request work is in Progress label Aug 16, 2021
@geoffrich geoffrich mentioned this issue Aug 16, 2021
Closed
geoffrich added a commit that referenced this issue Aug 17, 2021
@geoffrich
fix: reflect props and give default values #33
97ec130
@geoffrich geoffrich mentioned this issue Aug 17, 2021
Merged
3 tasks
blackfalcon pushed a commit that referenced this issue Aug 17, 2021
@geoffrich @blackfalcon
fix: reflect props and give default values #33
9ddfbbb
AuroDesignSystem pushed a commit that referenced this issue Aug 17, 2021
@semantic-release-bot
chore(release): 1.5.1 [skip ci]
2cdc218 
## [1.5.1](v1.5.0...v1.5.1) (2021-08-17)

### Bug Fixes

* update child state when group state changes [#49](#49) ([5cf4015](5cf4015))
* **auro-radio:** make error a boolean [#50](#50) ([34ba7af](34ba7af))
* reflect props and give default values [#33](#33) ([9ddfbbb](9ddfbbb))
@AuroDesignSystem
Copy link
Collaborator

🎉 This issue has been resolved in version 1.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AuroDesignSystem AuroDesignSystem added the released Completed work has been released label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

@geoffrich geoffrich

Labels
released Completed work has been released Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make individual error prop a boolean and sync child state with parent AlaskaAirlines/auro-radio
3 participants
@blackfalcon @geoffrich @AuroDesignSystem