Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-radio: updating disabled/required property on group does not update children #49

Closed
geoffrich opened this issue Aug 16, 2021 · 1 comment · Fixed by #51
Closed

auro-radio: updating disabled/required property on group does not update children #49

geoffrich opened this issue Aug 16, 2021 · 1 comment · Fixed by #51
Assignees
@blackfalcon @geoffrich
Labels
released Completed work has been released Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes

Comments

@geoffrich
Copy link
Contributor

Describe the bug

If you set disabled or required on the group after initial render, the child components are not updated appropriately.

For instance, if the group is initially required, but then required is set to false, the children still have required set to true.
Similarly, if the group is initially not disabled, but then disabled is set to true, the children still have disabled set to false and can be interacted with.

To Reproduce

Steps to reproduce the behavior:

  1. Render a radio-group that isn't disabled
  2. Query for the element in the console and set disabled to true
  3. The style does not change and the children are not disabled.

Expected behavior

Children are updated when the group properties change.

Additional context

Related: AlaskaAirlines/auro-checkbox#31
@geoffrich geoffrich added the Type: Bug Bug or Bug fixes label Aug 16, 2021
@geoffrich geoffrich added the Status: Work In Progress Issue or Pull Request work is in Progress label Aug 16, 2021
geoffrich added a commit that referenced this issue Aug 17, 2021
@geoffrich
fix: update child state when group state changes #49
76b0c41
@geoffrich geoffrich mentioned this issue Aug 17, 2021
Merged
3 tasks
blackfalcon pushed a commit that referenced this issue Aug 17, 2021
@geoffrich @blackfalcon
fix: update child state when group state changes #49
5cf4015
AuroDesignSystem pushed a commit that referenced this issue Aug 17, 2021
@semantic-release-bot
chore(release): 1.5.1 [skip ci]
2cdc218 
## [1.5.1](v1.5.0...v1.5.1) (2021-08-17)

### Bug Fixes

* update child state when group state changes [#49](#49) ([5cf4015](5cf4015))
* **auro-radio:** make error a boolean [#50](#50) ([34ba7af](34ba7af))
* reflect props and give default values [#33](#33) ([9ddfbbb](9ddfbbb))
@AuroDesignSystem
Copy link
Collaborator

🎉 This issue has been resolved in version 1.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AuroDesignSystem AuroDesignSystem added the released Completed work has been released label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

@geoffrich geoffrich

Labels
released Completed work has been released Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make individual error prop a boolean and sync child state with parent AlaskaAirlines/auro-radio
3 participants
@blackfalcon @geoffrich @AuroDesignSystem