Use Active Storage for Picture and File attachments #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
changed the title
tvdeyen
force-pushed
the
active-storage
branch
2 times, most recently
from
0b43fa0 to
2b7123c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2968 +/- ##
==========================================
- Coverage 96.58% 96.40% -0.19%
==========================================
Files 236 225 -11
Lines 6334 6261 -73
==========================================
- Hits 6118 6036 -82
- Misses 216 225 +9 ☔ View full report in Codecov by Sentry. |
tvdeyen
force-pushed
the
active-storage
branch
3 times, most recently
from
b4a85f8 to
9bedb48
Compare
|
It would be great to support uploads on the Resources, to use it when Alchemy is being used as admin for other models. |
|
This change is not related to allow attachments in Rails models. You can already do this with established Rails ways. There is nothing special about that in Alchemy. The model is yours. Just use it as normal Rails model. |
tvdeyen
commented
Sep 18, 2024
tvdeyen
commented
Sep 18, 2024
tvdeyen
force-pushed
the
active-storage
branch
2 times, most recently
from
59d4563 to
77a78ef
Compare
tvdeyen
force-pushed
the
active-storage
branch
2 times, most recently
from
b4a03f9 to
9587e59
Compare
tvdeyen
force-pushed
the
active-storage
branch
2 times, most recently
from
9b2e8f7 to
fd3afe9
Compare
Necessary for active storage image transforms
ActiveStorage uses the image_processing gem to process images. This uses a hash to describe the conversion instead of a string
Instead of using the Dragonfly Model validations we write our own. That way we can use another image attachment library more easily
The vips image_processing processor sharpens images by default. This disables this behavior.
Active storage already knows if a file is convertible
This avoids N+1 in the image library
Using activestorage methods to read the values. Ideally we would cache these values, but active storage asynchronously sets these values and provides no callback we could use.
Now that we use ActiveStorage we can remove our custom picture variant handling
This method is the only one left after the PictureVariant and PictureThumb removal.
Active storage has the mime type stored not the extension.
ruby-vips and mini_magick need to be told to ignore the page in order to resize animated gifs.
Before we where not telling active storage that we want a certain format explicitely. We need that for displaying animated PNGs properly.
Proxy downloads the file.
Only works in Rails 7.1
ActiveStorage expects an extension and not an mime type.
It is only configured by default in unreleased Rails 7.2
tvdeyen
force-pushed
the
active-storage
branch
from
fd3afe9 to
38b4972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Use ActiveStorage instead of Dragonfly for picture and file attachments.
Important changes
vips. It works withmini_magickthoughTODO
Alchemy::Attachmentas wellmini_magick(?? still a thing ??)Checklist