Added team possession function and parser for SciSports #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #201 +/- ##
===========================================
+ Coverage 98.03% 99.54% +1.51%
===========================================
Files 48 49 +1
Lines 4013 3731 -282
===========================================
- Hits 3934 3714 -220
+ Misses 79 17 -62 ☔ View full report in Codecov by Sentry. |
Alek050
added a commit
that referenced
this pull request
Jul 30, 2024
* Added possibility to load event data without metadata (#188) * Added new variables to fit with Sci V2 (#189) * Added possibility to load event data without metadata * Changes * Sync improvement trial (#191) * Added possibility to load event data without metadata * Changes * Improved synchronisation of passes and shots * Updated test * linters * changes * Added chardet to detect encoding for reading files (#193) * sci error (#197) * Added expected threat notebook and functionality for all databallpy events. (#200) * Created xT * changed create xt notebook * Start on updating xT * Added changes to xt * Updated xT notebook * Added calibration plot * Added xT functionality for all events * Changes * Added team possession function and parser for SciSports (#201) * Added parser for SciSports * Added feature to add team possession to tracking data * Removed commented code and added test * Changes to silence warnings (#202) * scisports bug * Solved bug in scisports * Fixed bug * respecified typing in match and base event * Added better typing * Improved synchronisation (#203) * Added function for acceleration and made save_match clip more robust (#204) * working on differentiate tests * Added function for acceleration and made visualization more robust * linters and changelog * requested chagnes * Inmotio bug (#207) * working on differentiate tests * Added function for acceleration and made visualization more robust * linters and changelog * requested chagnes * inmotio parser error * Removed sklearn as dependency, manual calculation of xG and xT (#209) * Changed xG and xT loading, now without sklearn, updated dependencies * new data files * Recovered typo * Added test (#210) * Refactor of synchronisation (#211) * Refactored synchronisation structure * Updated docstring * databallpy/utils/utils.py * Added test for match utils * Changed docstring in anonimyse_match * updated codecov version * updated codecov version * Added constants file (#212) * Added constants file * added constants.py * updated files for importing MISSING_INT * Refactor of event_dfs in Match class (#213) * refactor of event_dfs in Match class * Added test for match utils * Add date as property on Match (#215) * Add date as property on Match * Fix typo * Add test with no date * Fix lint * Try test with copy --------- Co-authored-by: Swopper050 <bram@witoos.nl> * Tests import error (#216) * changes * wft * Think I solved tests issue * Part 1: new docs (#222) * books trial * new ubunto * addes sphinx-requirements * more deps * conf.py added * req * removed sphinx-panels * changes * removed url * removed url * new try * Started on intro and getting-started page * Changes * changes * new docs * Finished preprocessing of getting started, changed some func naming for consistency * new requirements * req * reqs * new build * changes for readthedocs * Added static * Added static * Added static * new reqs.txt * new_saved_match * renamed to force non cache * new file * functionality changes * Added pressure and player possessions to docs (#223) * books trial * new ubunto * addes sphinx-requirements * more deps * conf.py added * req * removed sphinx-panels * changes * removed url * removed url * new try * Started on intro and getting-started page * Changes * changes * new docs * Finished preprocessing of getting started, changed some func naming for consistency * new requirements * req * reqs * new build * changes for readthedocs * Added static * Added static * Added static * new reqs.txt * new_saved_match * renamed to force non cache * new file * functionality changes * pressure notebook * 2 new features notebooks * Added space occupation (#225) * books trial * new ubunto * addes sphinx-requirements * more deps * conf.py added * req * removed sphinx-panels * changes * removed url * removed url * new try * Started on intro and getting-started page * Changes * changes * new docs * Finished preprocessing of getting started, changed some func naming for consistency * new requirements * req * reqs * new build * changes for readthedocs * Added static * Added static * Added static * new reqs.txt * new_saved_match * renamed to force non cache * new file * functionality changes * pressure notebook * 2 new features notebooks * temporary changes * space_occupation * added notebook * finalized changes for pitch control * changes in docs * Added contribution docs (#226) * anonimised_png * 194 enh covered distances (#224) * test commit 3-7-2024 * WIP covered_distance * update 10-7 * update 15-7 * 16-7 * Changed output from dict to pd df --------- Co-authored-by: Alexander Oonk <alexanderoonk26@gmail.com> * updated cicd workflow (#227) * updated workflow * changes * new checkout version * new checkout version * rerun linters * removed python version 3.10 * poetry for windows trial * poetry for windows trial * poetry for windows trial * fixed_windows_changes * fixed mistake in test for windows * Added marit as contributor * changes * changes in saving_matches for cross platform compatibility * new_macos_version * Removed support of python 3.9 * Added docs for covered distance (#229) * Docs for synchronisation (#228) * Added notebook on synchronising * Added sync notebook to git * changed_cicd_to_cover_docs * Small changes * trial 2 * trial 3 * trial 4 * trial 5 * trial 5 * trial 6 * changed codecov version * changed codecov version * changed codecov version * removed some spelling mistakes * started prepping for release * added sphinx documentation (#230) * added sphinx documentation * linters * ready for release? * mistake in readme * updated conf.py for autodoc --------- Co-authored-by: Bram <b.dewit@applyai.nl> Co-authored-by: Swopper050 <bram@witoos.nl> Co-authored-by: maritsloots <144918574+maritsloots@users.noreply.github.com>
Alek050
added a commit
that referenced
this pull request
Jul 30, 2024
* Added possibility to load event data without metadata (#188) * Added new variables to fit with Sci V2 (#189) * Added possibility to load event data without metadata * Changes * Sync improvement trial (#191) * Added possibility to load event data without metadata * Changes * Improved synchronisation of passes and shots * Updated test * linters * changes * Added chardet to detect encoding for reading files (#193) * sci error (#197) * Added expected threat notebook and functionality for all databallpy events. (#200) * Created xT * changed create xt notebook * Start on updating xT * Added changes to xt * Updated xT notebook * Added calibration plot * Added xT functionality for all events * Changes * Added team possession function and parser for SciSports (#201) * Added parser for SciSports * Added feature to add team possession to tracking data * Removed commented code and added test * Changes to silence warnings (#202) * scisports bug * Solved bug in scisports * Fixed bug * respecified typing in match and base event * Added better typing * Improved synchronisation (#203) * Added function for acceleration and made save_match clip more robust (#204) * working on differentiate tests * Added function for acceleration and made visualization more robust * linters and changelog * requested chagnes * Inmotio bug (#207) * working on differentiate tests * Added function for acceleration and made visualization more robust * linters and changelog * requested chagnes * inmotio parser error * Removed sklearn as dependency, manual calculation of xG and xT (#209) * Changed xG and xT loading, now without sklearn, updated dependencies * new data files * Recovered typo * Added test (#210) * Refactor of synchronisation (#211) * Refactored synchronisation structure * Updated docstring * databallpy/utils/utils.py * Added test for match utils * Changed docstring in anonimyse_match * updated codecov version * updated codecov version * Added constants file (#212) * Added constants file * added constants.py * updated files for importing MISSING_INT * Refactor of event_dfs in Match class (#213) * refactor of event_dfs in Match class * Added test for match utils * Add date as property on Match (#215) * Add date as property on Match * Fix typo * Add test with no date * Fix lint * Try test with copy --------- Co-authored-by: Swopper050 <bram@witoos.nl> * Tests import error (#216) * changes * wft * Think I solved tests issue * Part 1: new docs (#222) * books trial * new ubunto * addes sphinx-requirements * more deps * conf.py added * req * removed sphinx-panels * changes * removed url * removed url * new try * Started on intro and getting-started page * Changes * changes * new docs * Finished preprocessing of getting started, changed some func naming for consistency * new requirements * req * reqs * new build * changes for readthedocs * Added static * Added static * Added static * new reqs.txt * new_saved_match * renamed to force non cache * new file * functionality changes * Added pressure and player possessions to docs (#223) * books trial * new ubunto * addes sphinx-requirements * more deps * conf.py added * req * removed sphinx-panels * changes * removed url * removed url * new try * Started on intro and getting-started page * Changes * changes * new docs * Finished preprocessing of getting started, changed some func naming for consistency * new requirements * req * reqs * new build * changes for readthedocs * Added static * Added static * Added static * new reqs.txt * new_saved_match * renamed to force non cache * new file * functionality changes * pressure notebook * 2 new features notebooks * Added space occupation (#225) * books trial * new ubunto * addes sphinx-requirements * more deps * conf.py added * req * removed sphinx-panels * changes * removed url * removed url * new try * Started on intro and getting-started page * Changes * changes * new docs * Finished preprocessing of getting started, changed some func naming for consistency * new requirements * req * reqs * new build * changes for readthedocs * Added static * Added static * Added static * new reqs.txt * new_saved_match * renamed to force non cache * new file * functionality changes * pressure notebook * 2 new features notebooks * temporary changes * space_occupation * added notebook * finalized changes for pitch control * changes in docs * Added contribution docs (#226) * anonimised_png * 194 enh covered distances (#224) * test commit 3-7-2024 * WIP covered_distance * update 10-7 * update 15-7 * 16-7 * Changed output from dict to pd df --------- Co-authored-by: Alexander Oonk <alexanderoonk26@gmail.com> * updated cicd workflow (#227) * updated workflow * changes * new checkout version * new checkout version * rerun linters * removed python version 3.10 * poetry for windows trial * poetry for windows trial * poetry for windows trial * fixed_windows_changes * fixed mistake in test for windows * Added marit as contributor * changes * changes in saving_matches for cross platform compatibility * new_macos_version * Removed support of python 3.9 * Added docs for covered distance (#229) * Docs for synchronisation (#228) * Added notebook on synchronising * Added sync notebook to git * changed_cicd_to_cover_docs * Small changes * trial 2 * trial 3 * trial 4 * trial 5 * trial 5 * trial 6 * changed codecov version * changed codecov version * changed codecov version * removed some spelling mistakes * added sphinx documentation (#230) * added sphinx documentation * linters * 0.5.0 release (#232) * started prepping for release * ready for release? * mistake in readme * updated conf.py for autodoc * fixed readme badge --------- Co-authored-by: Bram <b.dewit@applyai.nl> Co-authored-by: Swopper050 <bram@witoos.nl> Co-authored-by: maritsloots <144918574+maritsloots@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.