Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add date as property on Match #215

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Add date as property on Match #215

merged 6 commits into from
Apr 29, 2024

Conversation

Swopper050
Copy link
Contributor

Closes #214

@codecov Codecov
Copy link

codecov bot commented Apr 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (e4ce2b3) to head (6319f11).
Report is 5 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #215      +/-   ##
===========================================
- Coverage    99.22%   99.10%   -0.13%     
===========================================
  Files           49       52       +3     
  Lines         3736     3781      +45     
===========================================
+ Hits          3707     3747      +40     
- Misses          29       34       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swopper050
Copy link
Contributor Author

@Alek050 Do you know why the codecov patch is failing? I'm not sure how to add coverage to the two lines it says its missing

@Alek050
Copy link
Owner

Alek050 commented Apr 28, 2024

Hi @Swopper050

I am not really sure what is happening, Codecov has been working poorly lately but have not seen this before. However, I think you do not have the latest version of develop merged in your branch. In match.py, the methods shots_df, passes_df, and dribbles_df are calculated differently on Alek050/databallpy/develop than on your code. Could you try pulling and merging develop in you branch and rerunning the actions after this change?

@Swopper050
Copy link
Contributor Author

Swopper050 commented Apr 29, 2024 •
edited
Loading

@Alek050 I think I branched from main. Should be updated now. Seems the codecov still fails, but I don't think it's due to my changes.

@Alek050
Copy link
Owner

Alek050 commented Apr 29, 2024

Looks like it fails on some of the lines I updated in an earlier PR, but back then Codecov was not working properly. I'll approve the PR.

@Alek050 Alek050 merged commit 4d29937 into Alek050:develop Apr 29, 2024
2 of 3 checks passed
@Swopper050 Swopper050 deleted the 214-add-date-on-match branch April 29, 2024 14:22
Alek050 added a commit that referenced this pull request Jul 30, 2024
@Alek050 @Swopper050 @maritsloots
0.5.0 release (#231)
7d386e0 
* Added possibility to load event data without metadata (#188)

* Added new variables to fit with Sci V2 (#189)

* Added possibility to load event data without metadata

* Changes

* Sync improvement trial (#191)

* Added possibility to load event data without metadata

* Changes

* Improved synchronisation of passes and shots

* Updated test

* linters

* changes

* Added chardet to detect encoding for reading files (#193)

* sci error (#197)

* Added expected threat notebook and functionality for all databallpy events. (#200)

* Created xT

* changed create xt notebook

* Start on updating xT

* Added changes to xt

* Updated xT notebook

* Added calibration plot

* Added xT functionality for all events

* Changes

* Added team possession function and parser for SciSports (#201)

* Added parser for SciSports

* Added feature to add team possession to tracking data

* Removed commented code and added test

* Changes to silence warnings (#202)

* scisports bug

* Solved bug in scisports

* Fixed bug

* respecified typing in match and base event

* Added better typing

* Improved synchronisation (#203)

* Added function for acceleration and made save_match clip more robust (#204)

* working on differentiate tests

* Added function for acceleration and made visualization more robust

* linters and changelog

* requested chagnes

* Inmotio bug (#207)

* working on differentiate tests

* Added function for acceleration and made visualization more robust

* linters and changelog

* requested chagnes

* inmotio parser error

* Removed sklearn as dependency, manual calculation of xG and xT (#209)

* Changed xG and xT loading, now without sklearn, updated dependencies

* new data files

* Recovered typo

* Added test (#210)

* Refactor of synchronisation (#211)

* Refactored synchronisation structure

* Updated docstring

* databallpy/utils/utils.py

* Added test for match utils

* Changed docstring in anonimyse_match

* updated codecov version

* updated codecov version

* Added constants file (#212)

* Added constants file

* added constants.py

* updated files for importing MISSING_INT

* Refactor of event_dfs in Match class (#213)

* refactor of event_dfs in Match class

* Added test for match utils

* Add date as property on Match (#215)

* Add date as property on Match

* Fix typo

* Add test with no date

* Fix lint

* Try test with copy

---------

Co-authored-by: Swopper050 <bram@witoos.nl>

* Tests import error (#216)

* changes

* wft

* Think I solved tests issue

* Part 1: new docs (#222)

* books trial

* new ubunto

* addes sphinx-requirements

* more deps

* conf.py added

* req

* removed sphinx-panels

* changes

* removed url

* removed url

* new try

* Started on intro and getting-started page

* Changes

* changes

* new docs

* Finished preprocessing of getting started, changed some func naming for consistency

* new requirements

* req

* reqs

* new build

* changes for readthedocs

* Added static

* Added static

* Added static

* new reqs.txt

* new_saved_match

* renamed to force non cache

* new file

* functionality changes

* Added pressure and player possessions to docs (#223)

* books trial

* new ubunto

* addes sphinx-requirements

* more deps

* conf.py added

* req

* removed sphinx-panels

* changes

* removed url

* removed url

* new try

* Started on intro and getting-started page

* Changes

* changes

* new docs

* Finished preprocessing of getting started, changed some func naming for consistency

* new requirements

* req

* reqs

* new build

* changes for readthedocs

* Added static

* Added static

* Added static

* new reqs.txt

* new_saved_match

* renamed to force non cache

* new file

* functionality changes

* pressure notebook

* 2 new features notebooks

* Added space occupation (#225)

* books trial

* new ubunto

* addes sphinx-requirements

* more deps

* conf.py added

* req

* removed sphinx-panels

* changes

* removed url

* removed url

* new try

* Started on intro and getting-started page

* Changes

* changes

* new docs

* Finished preprocessing of getting started, changed some func naming for consistency

* new requirements

* req

* reqs

* new build

* changes for readthedocs

* Added static

* Added static

* Added static

* new reqs.txt

* new_saved_match

* renamed to force non cache

* new file

* functionality changes

* pressure notebook

* 2 new features notebooks

* temporary changes

* space_occupation

* added notebook

* finalized changes for pitch control

* changes in docs

* Added contribution docs (#226)

* anonimised_png

* 194 enh covered distances (#224)

* test commit 3-7-2024

* WIP covered_distance

* update 10-7

* update 15-7

* 16-7

* Changed output from dict to pd df

---------

Co-authored-by: Alexander Oonk <alexanderoonk26@gmail.com>

* updated cicd workflow (#227)

* updated workflow

* changes

* new checkout version

* new checkout version

* rerun linters

* removed python version 3.10

* poetry for windows trial

* poetry for windows trial

* poetry for windows trial

* fixed_windows_changes

* fixed mistake in test for windows

* Added marit as contributor

* changes

* changes in saving_matches for cross platform compatibility

* new_macos_version

* Removed support of python 3.9

* Added docs for covered distance (#229)

* Docs for synchronisation (#228)

* Added notebook on synchronising

* Added sync notebook to git

* changed_cicd_to_cover_docs

* Small changes

* trial 2

* trial 3

* trial 4

* trial 5

* trial 5

* trial 6

* changed codecov version

* changed codecov version

* changed codecov version

* removed some spelling mistakes

* started prepping for release

* added sphinx documentation (#230)

* added sphinx documentation

* linters

* ready for release?

* mistake in readme

* updated conf.py for autodoc

---------

Co-authored-by: Bram <b.dewit@applyai.nl>
Co-authored-by: Swopper050 <bram@witoos.nl>
Co-authored-by: maritsloots <144918574+maritsloots@users.noreply.github.com>
Alek050 added a commit that referenced this pull request Jul 30, 2024
@Alek050 @Swopper050 @maritsloots
Fixed badge link (#233)
6ea395a 
* Added possibility to load event data without metadata (#188)

* Added new variables to fit with Sci V2 (#189)

* Added possibility to load event data without metadata

* Changes

* Sync improvement trial (#191)

* Added possibility to load event data without metadata

* Changes

* Improved synchronisation of passes and shots

* Updated test

* linters

* changes

* Added chardet to detect encoding for reading files (#193)

* sci error (#197)

* Added expected threat notebook and functionality for all databallpy events. (#200)

* Created xT

* changed create xt notebook

* Start on updating xT

* Added changes to xt

* Updated xT notebook

* Added calibration plot

* Added xT functionality for all events

* Changes

* Added team possession function and parser for SciSports (#201)

* Added parser for SciSports

* Added feature to add team possession to tracking data

* Removed commented code and added test

* Changes to silence warnings (#202)

* scisports bug

* Solved bug in scisports

* Fixed bug

* respecified typing in match and base event

* Added better typing

* Improved synchronisation (#203)

* Added function for acceleration and made save_match clip more robust (#204)

* working on differentiate tests

* Added function for acceleration and made visualization more robust

* linters and changelog

* requested chagnes

* Inmotio bug (#207)

* working on differentiate tests

* Added function for acceleration and made visualization more robust

* linters and changelog

* requested chagnes

* inmotio parser error

* Removed sklearn as dependency, manual calculation of xG and xT (#209)

* Changed xG and xT loading, now without sklearn, updated dependencies

* new data files

* Recovered typo

* Added test (#210)

* Refactor of synchronisation (#211)

* Refactored synchronisation structure

* Updated docstring

* databallpy/utils/utils.py

* Added test for match utils

* Changed docstring in anonimyse_match

* updated codecov version

* updated codecov version

* Added constants file (#212)

* Added constants file

* added constants.py

* updated files for importing MISSING_INT

* Refactor of event_dfs in Match class (#213)

* refactor of event_dfs in Match class

* Added test for match utils

* Add date as property on Match (#215)

* Add date as property on Match

* Fix typo

* Add test with no date

* Fix lint

* Try test with copy

---------

Co-authored-by: Swopper050 <bram@witoos.nl>

* Tests import error (#216)

* changes

* wft

* Think I solved tests issue

* Part 1: new docs (#222)

* books trial

* new ubunto

* addes sphinx-requirements

* more deps

* conf.py added

* req

* removed sphinx-panels

* changes

* removed url

* removed url

* new try

* Started on intro and getting-started page

* Changes

* changes

* new docs

* Finished preprocessing of getting started, changed some func naming for consistency

* new requirements

* req

* reqs

* new build

* changes for readthedocs

* Added static

* Added static

* Added static

* new reqs.txt

* new_saved_match

* renamed to force non cache

* new file

* functionality changes

* Added pressure and player possessions to docs (#223)

* books trial

* new ubunto

* addes sphinx-requirements

* more deps

* conf.py added

* req

* removed sphinx-panels

* changes

* removed url

* removed url

* new try

* Started on intro and getting-started page

* Changes

* changes

* new docs

* Finished preprocessing of getting started, changed some func naming for consistency

* new requirements

* req

* reqs

* new build

* changes for readthedocs

* Added static

* Added static

* Added static

* new reqs.txt

* new_saved_match

* renamed to force non cache

* new file

* functionality changes

* pressure notebook

* 2 new features notebooks

* Added space occupation (#225)

* books trial

* new ubunto

* addes sphinx-requirements

* more deps

* conf.py added

* req

* removed sphinx-panels

* changes

* removed url

* removed url

* new try

* Started on intro and getting-started page

* Changes

* changes

* new docs

* Finished preprocessing of getting started, changed some func naming for consistency

* new requirements

* req

* reqs

* new build

* changes for readthedocs

* Added static

* Added static

* Added static

* new reqs.txt

* new_saved_match

* renamed to force non cache

* new file

* functionality changes

* pressure notebook

* 2 new features notebooks

* temporary changes

* space_occupation

* added notebook

* finalized changes for pitch control

* changes in docs

* Added contribution docs (#226)

* anonimised_png

* 194 enh covered distances (#224)

* test commit 3-7-2024

* WIP covered_distance

* update 10-7

* update 15-7

* 16-7

* Changed output from dict to pd df

---------

Co-authored-by: Alexander Oonk <alexanderoonk26@gmail.com>

* updated cicd workflow (#227)

* updated workflow

* changes

* new checkout version

* new checkout version

* rerun linters

* removed python version 3.10

* poetry for windows trial

* poetry for windows trial

* poetry for windows trial

* fixed_windows_changes

* fixed mistake in test for windows

* Added marit as contributor

* changes

* changes in saving_matches for cross platform compatibility

* new_macos_version

* Removed support of python 3.9

* Added docs for covered distance (#229)

* Docs for synchronisation (#228)

* Added notebook on synchronising

* Added sync notebook to git

* changed_cicd_to_cover_docs

* Small changes

* trial 2

* trial 3

* trial 4

* trial 5

* trial 5

* trial 6

* changed codecov version

* changed codecov version

* changed codecov version

* removed some spelling mistakes

* added sphinx documentation (#230)

* added sphinx documentation

* linters

* 0.5.0 release (#232)

* started prepping for release

* ready for release?

* mistake in readme

* updated conf.py for autodoc

* fixed readme badge

---------

Co-authored-by: Bram <b.dewit@applyai.nl>
Co-authored-by: Swopper050 <bram@witoos.nl>
Co-authored-by: maritsloots <144918574+maritsloots@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alek050 Alek050 Alek050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swopper050 @Alek050