[HackerOne-2310746] Add fee check to transmissions fetched in batch proposal. #3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 1, 2024
…/simple-proposal-transmission-check
raychu86
force-pushed
the
feat/simple-proposal-transmission-check
branch
from
af95fff to
f8c2827
Compare
howardwu
approved these changes
Mar 4, 2024
howardwu
reviewed
Mar 4, 2024
| let mut transmissions = self.sync_with_batch_header_from_peer(peer_ip, &batch_header).await?; | ||
|
|
||
| // Check that the transmission ids match and are not fee transactions. | ||
| for (transmission_id, transmission) in transmissions.iter_mut() { |
There was a problem hiding this comment.
@ljedrz can you profile this and determine if an optimization is possible with rayon or tokio?
There was a problem hiding this comment.
Feel free to open a new PR if so
There was a problem hiding this comment.
Note that the number of transmissions here can be up to 50, and each one will be deserializing the Transmission Data object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR performs basic checks on transmissions fetched from batch proposals. We now check that the transmission id's match and that the transmission is not a
Feetransaction.This fix does not address all the issues, but is an added mitigation for the malicious Fee transmission case. This is an incremental fix for #3098.
Related PRs
This PR is related to #3098, and is a simpler approach that addresses one case of the problem.
This PR fixes #2990, but is insufficient for #2991.