New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HackerOne-2300725] Limit the number of allowed constraints for deployments #2271

Merged

howardwu merged 40 commits into mainnet from limit_deployment_num_constraints

Feb 9, 2024

Contributor

vicsn commented Dec 29, 2023 •

edited

Loading

Motivation

Large deployments may take a lot of time to synthesize, so as an initial stopgap we can limit their size, as measurement by the number of constraints.

Note that the current approach panics on failure, but because check_transaction_basic is called from snarkOS in a tokio task, this panic is gracefully handled. Returning a Result would cascade to 100 other functions using the Circuit api.

Test Plan

Manually test deploying to a validator via RPC. Prevents large deployments succesfully. Even with a manipulated verifying_key.
Check that the synthesizer benchmarks don't take a big hit
Add a test deploying a program which is too big.

Related PRs

https://github.com/AleoHQ/snarkOS/pull/2961


          Limit the number of allowed constraints for deployments

88364b0

vicsn requested a review from iamalwaysuncomfortable

December 29, 2023 19:08

vicsn mentioned this pull request

Minor refactor to fit update to cost function updates AleoNet/snarkOS#2961

Closed

vicsn added 3 commits

December 29, 2023 21:27


          Increase allowed number of deployment constraints for existing test s…

5e0e2f6

…uite


          Correct test expectations. The RNG depends on FinalizeState

f429701


          Add test for too many constraints

696d332

vicsn mentioned this pull request

Limit amount of transactions which clients verify in parallel AleoNet/snarkOS#2970

Closed

vicsn marked this pull request as ready for review

January 5, 2024 12:39

howardwu requested a review from ljedrz

January 9, 2024 03:58

ljedrz reviewed

View reviewed changes

circuit/environment/src/circuit.rs Outdated Show resolved Hide resolved

ljedrz reviewed

View reviewed changes

circuit/environment/src/circuit.rs Outdated Show resolved Hide resolved

ljedrz reviewed

View reviewed changes

circuit/environment/src/circuit.rs Outdated Show resolved Hide resolved

ljedrz reviewed

View reviewed changes

ledger/block/src/transaction/deployment/mod.rs Outdated Show resolved Hide resolved

ljedrz reviewed

View reviewed changes

synthesizer/process/src/stack/deploy.rs Show resolved Hide resolved

ljedrz reviewed

View reviewed changes

synthesizer/src/vm/helpers/cost.rs Outdated Show resolved Hide resolved

ljedrz reviewed

View reviewed changes

synthesizer/src/vm/mod.rs Show resolved Hide resolved

ljedrz reviewed

View reviewed changes

Collaborator

ljedrz left a comment

Left a few comments and suggestions.

ljedrz mentioned this pull request

[Bug] Deploying programs with certain set of constraints causes OOM errors on validators #2293

Closed

vicsn commented

View reviewed changes

synthesizer/src/vm/helpers/cost.rs Outdated Show resolved Hide resolved

This was referenced Jan 10, 2024

Add fixed execution cost #2294

Closed

[Stress-06] Price Finalize Opcodes Based On Operand Types #2281

Merged

vicsn added 7 commits

January 10, 2024 17:10


          Actually limit at max_constraints

d872a42


          Use Self::set_constraint_maximum

0be9950


          Comment nit

06ab667


          Convert type early

6b6fc40


          Check that the number of functions matches the number of verifying keys

726a614


          Clean up deployment_cost function


          Nit: fix comment

5d3c2b7

vicsn changed the title ~~Limit the number of allowed constraints for deployments~~ WIP: Limit the number of allowed constraints for deployments

vicsn changed the title ~~WIP: Limit the number of allowed constraints for deployments~~ Limit the number of allowed constraints for deployments

Contributor

evan-schott commented Jan 22, 2024

@evan-schott can you help finish the two tests in 01b95d2 and look at fixing any broken CI tests? We can discuss further in person.

I will investigate

Contributor

raychu86 commented Jan 27, 2024

Is there a reason more CI tests are failing? Do we need to resample anything?

evan-schott added 7 commits

January 30, 2024 22:21


          Remove redundant check

cc87b98


          Revise tests

1b02d5c


          Modify constraint limit to account for the constraint added after syn…

1ae6626

…thesis that randomizes vars


          Add back synthesis check to catch overreports

32053f9


          tx id changes bc deploy fee increased w/ this PR

ff10297


          revise new tests

32d3ca4


          clippy

7d443bc

vicsn commented

View reviewed changes

synthesizer/process/src/stack/deploy.rs Outdated Show resolved Hide resolved

vicsn commented

View reviewed changes

synthesizer/process/src/stack/execute.rs Outdated Show resolved Hide resolved

evan-schott added 2 commits

February 2, 2024 13:24


          fixes

763d5fe


          fixes

6adc557

evan-schott requested review from howardwu and raychu86

February 2, 2024 19:56

Contributor Author

vicsn commented Feb 2, 2024

LGTM!

vicsn added 3 commits

February 8, 2024 08:17


          Correct underreport test program name

b746a19


          Merge remote-tracking branch 'origin/mainnet' into limit_deployment_n…

ed6cfa7

…um_constraints


          Correct test expectations

58e6c39

howardwu reviewed

View reviewed changes

synthesizer/process/src/stack/call/mod.rs

Comment on lines +385 to +389

+                          // If in 'CheckDeployment' mode, set the expected constraint limit.
+                          if let CallStack::CheckDeployment(_, _, _, constraint_limit) = &registers.call_stack() {
+                              A::set_constraint_limit(*constraint_limit);
+                          }

Contributor

howardwu Feb 9, 2024

I'm not convinced this logic is necessary.

When triggering call, no logic above this resets the constraint limit AFAIK.


          nit: use let-else syntax

411218b

howardwu mentioned this pull request

Extraneous set_constraint_limit usage #2339

Closed

howardwu approved these changes

View reviewed changes

howardwu merged commit ee6b2da into mainnet

64 of 78 checks passed

howardwu deleted the limit_deployment_num_constraints branch

February 9, 2024 02:26

howardwu mentioned this pull request

[Tracking] Pre-release of the mainnet branch #2199

Draft

raychu86 changed the title ~~Limit the number of allowed constraints for deployments~~ [HackerOne-2300725] Limit the number of allowed constraints for deployments

vicsn mentioned this pull request

Program Deployments Acceptance Criteria monadicus/snarkops#5

Closed

2 tasks

vicsn mentioned this pull request

Introduce deployment variable limit and cost #2431

Closed

howardwu mentioned this pull request

Adds a variable limit for deployments #2444

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mainnet-candidate