Authorization deserialization fix #2478
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When deserializing an
Authorization
from string a call stack that included multiple transitions, the structural assertion logic would erroneously fail. This PR fixes the assertion logic but does not change the underlying structure/order of theAuthorization
fields.Test Plan
Our (Puzzle) delegated proving stack takes in user-generated
Authorization
s in string form. We then parse these and execute the proof request using snarkVM crates. I've tested that theseAuthorization
deserializations and subsequent proofs do indeed land onchain properly.I can provide screenshots/videos on request. For now, you can see the following transaction that was generated through our stack and has landed onchain: https://testnet.aleoscan.io/transaction?id=at14d4edujs6ztghev2zppp55v4xlffu7q3p379dlvdsu3yuu2cluysd84ktk
I am also willing to create a sample project showing this fix in action.
A more formal test plan would involve embedding a multi-transition
Authorization
unit test into snarkVM itself and not just relying on afee_public
test case.Related PRs
none