This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 99
Allow to use custom repository #15
Comments
Oh, it's more complicated then I expected. I'll leave 'include' section for 'clickhouse_supported' but will move repo/key things to defaults. Is it ok? |
amarao
added a commit
to amarao/ansible-clickhouse
that referenced
this issue
May 15, 2018
Now it's possible to define own clickhouse_repo variable to prove apt source line to use. Now it's possible to define own key id and keyserver to download the apt key, or to provide the apt key within a variable `clickhouse_repo_key_data`. Closes: AlexeySetevoi#15
I think it should be okay. I also don't know, why it was per Distro included. |
@amarao Could you make PR for your commit, to get your changes done and also resolve this issue? |
amarao
added a commit
to amarao/ansible-clickhouse
that referenced
this issue
Sep 6, 2018
prove an apt configuration string to use. Also it's possible to define own key id and/or keyserver to download the apt key, and/or to provide the apt key within a variable `clickhouse_repo_key_data`. Closes: AlexeySetevoi#15
I done this in #17 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We have a policy to use local mirrors for all external packages. That means, to use clickhouse in production I need to create a local mirror and to change the ansible-clickhouse role to use that mirror.
When I've tried to use custom
clickhouse_repo
variable I found that ansible-clickhouse uses 'include_vars' which overrides variables from the calling playbook. Moreover, I found that all three files to include (vars/Ubuntu_trusty.yml
,Ubuntu_precise.yml
andUbuntu_xenial.yml
) are identical (except for a single empty line).To achieve my goal (use of custom repositories) I'd like to do four things:
clickhouse_repo_key_data
(not defined by default).clickhouse_repo_key_data
make role to use it instead ofclickhouse_repo_keyserver
andclickhouse_repo_key
to add that key intoapt_key
(withdata
option).Is it ok?
The text was updated successfully, but these errors were encountered: