Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Allow to use custom repository #15

Open
amarao opened this issue May 15, 2018 · 4 comments
Open

Allow to use custom repository #15

amarao opened this issue May 15, 2018 · 4 comments

Comments

@amarao
Copy link
Contributor

amarao commented May 15, 2018

We have a policy to use local mirrors for all external packages. That means, to use clickhouse in production I need to create a local mirror and to change the ansible-clickhouse role to use that mirror.

When I've tried to use custom clickhouse_repo variable I found that ansible-clickhouse uses 'include_vars' which overrides variables from the calling playbook. Moreover, I found that all three files to include (vars/Ubuntu_trusty.yml, Ubuntu_precise.yml and Ubuntu_xenial.yml) are identical (except for a single empty line).

To achieve my goal (use of custom repositories) I'd like to do four things:

  1. Move all variables from Ubuntu* files into defaults.
  2. Remove include_var statement
  3. Add variable clickhouse_repo_key_data (not defined by default).
  4. In case of clickhouse_repo_key_data make role to use it instead of clickhouse_repo_keyserver and clickhouse_repo_key to add that key into apt_key (with data option).

Is it ok?

@amarao
Copy link
Contributor Author

amarao commented May 15, 2018

Oh, it's more complicated then I expected. I'll leave 'include' section for 'clickhouse_supported' but will move repo/key things to defaults. Is it ok?

amarao added a commit to amarao/ansible-clickhouse that referenced this issue May 15, 2018
Now it's possible to define own clickhouse_repo variable to
prove apt source line to use.

Now it's possible to define own key id and keyserver to download
the apt key, or to provide the apt key within a variable
`clickhouse_repo_key_data`.

Closes: AlexeySetevoi#15
@krzyzakp
Copy link
Contributor

I think it should be okay. I also don't know, why it was per Distro included.
When my PR #16 will be merged, we can see if it's working in TravisCI.

@krzyzakp
Copy link
Contributor

@amarao Could you make PR for your commit, to get your changes done and also resolve this issue?

amarao added a commit to amarao/ansible-clickhouse that referenced this issue Sep 6, 2018
prove an apt configuration string to use.

Also it's possible to define own key id and/or keyserver to download
the apt key, and/or to provide the apt key within a variable
`clickhouse_repo_key_data`.

Closes: AlexeySetevoi#15
@amarao
Copy link
Contributor Author

amarao commented Sep 6, 2018

I done this in #17

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants