Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Private mirrors2 #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

amarao
Copy link
Contributor

@amarao amarao commented Sep 6, 2018

  • Add support for private mirrors
  • Add support for Ubuntu Bionic
  • Add Debian Stretch, Jessie and Ubuntu Bionic into test suites
  • Replace clickhouse_supported variable with explicit list of clickhouse_supported_distros
  • Remove includes for distro-specific variables (as they were the same for all supported distros)
  • Add information on private repositories into Readme.

prove an apt configuration string to use.

Also it's possible to define own key id and/or keyserver to download
the apt key, and/or to provide the apt key within a variable
`clickhouse_repo_key_data`.

Closes: AlexeySetevoi#15
@@ -24,6 +24,18 @@ matrix:
dist: xenial
sudo: true
env: ANSIBLE_VERSION='ansible>=2.3,<2.4'
- os: linux
dist: bionic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I took a look on: https://docs.travis-ci.com/user/reference/overview/ - this OS, same as Debian are not supported by Travis.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. This is heavily outdated CI. I saw their comment on adding Xenial support in 2017... And still none was done.

What is your suggestion here? Remove debian/xenial/bionic from tests?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have any direct impact on that CI, except making issue/request to them. Best would be to remove them from tests, if they're just running default image, which is tested anyway.

Travis supports only for trusty, so other distros couldn't
be tested.

Now there is a clickhouse_supported_distros list with list
of supported versions in form of string:
'{{ ansible_distribution }}_{{ ansible_distribution_release }}'
@amarao
Copy link
Contributor Author

amarao commented Sep 14, 2018

Okay. I've trimmed all tests down to Trusty. Sad story.

@AlexeySetevoi
Copy link
Owner

AlexeySetevoi commented Sep 14, 2018

Falled builds for stretch, bionic and jessie. This distros have no support from travis, fallback to precise(sic!) and glibc errors)). Please remove this distros from matrix, then i ready to merge your improvements.

@amarao
Copy link
Contributor Author

amarao commented Oct 3, 2018

I don't understand why tests are failing.

/usr/bin/clickhouse-extract-from-config: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.18' not found (required by /usr/bin/clickhouse-extract-from-config)

Is it related to mirror configuration? I don't feel so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants