-
Notifications
You must be signed in to change notification settings - Fork 67
Part 5 of n: SNV caller initial calculations #134
Part 5 of n: SNV caller initial calculations #134
Conversation
…cansav09/snv_calculations
…cansav09/snv_calculations
The first three datasets passed through the Circle CI check fine, but it has failed because of VarDict. The problems with the VarDict file have been noted. But unfortunately my test won't work until that's resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Definitely like the extra file structure. A few comments, mostly minor, including some simplifications for the overwrite logic.
…cansav09/snv_calculations
Okay, made the suggested changes, @jashapiro and things are working fine. What do you think? |
84c0f4b
to
4666b00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just needs a quick fix on the comments to reflect the recent changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Moving on...
I'm temporarily removing VarDict from the analysis until #135 is unresolved. This way the Circle CI tests will pass and then this can be merged. VarDict needs to be added back to this analysis after #135 is resolved. This issue is tracked here. |
Purpose/implementation
This is the fifth PR in a series that are preparing a pipeline to perform an initial analysis and calculation of each MAF file for each SNV caller. At this point, the SNV callers that will be evaluated are MuTect2, Strelka2, VarDict, and Lancet.
What these scripts do:
01-calculate_vaf_tmb.R
is called from therun_caller_evals.sh
bash script and sets up and creates the VAF, TMB, and other files for each dataset based on the options provided. It uses functions fromutil/wrangle_functions.R
and will run the00-set_up.R
script at the very beginning so it makes sure the files needed exist.These are the files it creates in a results folder for each dataset:
Issue
For SNV caller comparison #103 and Tumor Mutation Burden #3 and sort of #11
Directions for reviewers
Main things I am looking for advice on:
00-set_up.R
? What should be changed/optimized?optparse
options?rprojroot::find_root
for getting the directories method?Results
No results just yet, because we don't yet have all the data.
Docker and continuous integration
(From Part 4 of n: SNV Caller Analysis: Set Up Script #126, no changes have been made to the Dockerfile.)
PR Checklist