Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Quick edits to speed up Circle CI tests #163

Merged
merged 5 commits into from
Oct 23, 2019

Conversation

cansavvy
Copy link
Collaborator

@cansavvy cansavvy commented Oct 23, 2019

Purpose/implementation

CircleCI tests take ~11 min in part due to some of the snv caller tests and largeness of the VarDict file (even when it is subset).

Vaf filter has been upped from 0.10 to 0.25, this should cut down the VarDict file some more and speed up some of the analysis steps.

Issue

NA

Results

NA

Docker and continuous integration

  • This analysis has been added to continuous integration.

@jaclyn-taroni
Copy link
Member

This still takes over 8 minutes. Is there anything you think you would not be thoroughly testing if you raised the cutoff further?

@jashapiro
Copy link
Member

jashapiro commented Oct 23, 2019

One other speedup that seems worth doing... hg38_genomic_region_annotation.rds is not too big for github, and generating it takes a good couple minutes every time. It's only 40MB, and won't change often, so it seems reasonable to include it in the repo. Thoughts?

@cansavvy
Copy link
Collaborator Author

That sounds good, @jashapiro I will do that change.

@jaclyn-taroni
Copy link
Member

I would still try increasing the cutoff further, unless that would prevent something from being tested.

@cansavvy
Copy link
Collaborator Author

I would still try increasing the cutoff further, unless that would prevent something from being tested.

I've upped it to 0.5.

Another way to decrease the run time for snv caller bit is to turn off the regional analysis which I made an option for on another branch. Although I think it is a good analysis to do, I think it would be better to do it after we reach a consensus. The results of that analysis haven't added to the consensus mutation decisions. Thoughts?

@jaclyn-taroni
Copy link
Member

You're referencing #159 (comment) correct? Let's have that discussion over there.

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️

@jaclyn-taroni
Copy link
Member

Was removing wxs_bed_regions_all.tsv intentional?

@cansavvy
Copy link
Collaborator Author

Was removing wxs_bed_regions_all.tsv intentional?

Yes it is an old development remnant that was a place holder before v5 data was released and had the actual BED regions files. It should be removed.

@jaclyn-taroni jaclyn-taroni merged commit 3575c76 into AlexsLemonade:master Oct 23, 2019
@cansavvy cansavvy deleted the up_vaf_filter branch December 19, 2019 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants