-
Notifications
You must be signed in to change notification settings - Fork 67
Quick edits to speed up Circle CI tests #163
Conversation
This still takes over 8 minutes. Is there anything you think you would not be thoroughly testing if you raised the cutoff further? |
One other speedup that seems worth doing... |
That sounds good, @jashapiro I will do that change. |
I would still try increasing the cutoff further, unless that would prevent something from being tested. |
I've upped it to 0.5. Another way to decrease the run time for snv caller bit is to turn off the regional analysis which I made an option for on another branch. Although I think it is a good analysis to do, I think it would be better to do it after we reach a consensus. The results of that analysis haven't added to the consensus mutation decisions. Thoughts? |
You're referencing #159 (comment) correct? Let's have that discussion over there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚡️
Was removing |
Yes it is an old development remnant that was a place holder before v5 data was released and had the actual BED regions files. It should be removed. |
Purpose/implementation
CircleCI tests take ~11 min in part due to some of the snv caller tests and largeness of the VarDict file (even when it is subset).
Vaf filter has been upped from 0.10 to 0.25, this should cut down the VarDict file some more and speed up some of the analysis steps.
Issue
NA
Results
NA
Docker and continuous integration