-
Notifications
You must be signed in to change notification settings - Fork 67
Draft PR: SNV Caller Comparison Notebook #159
Conversation
…cansav09/snv_calculations
Two Updates:I made the changes to the version of the original notebook: Here's a rough draft of the VAF cutoff experiment. Let me know what other plots I should include. I think for it's full-fledged review I will make it its own PR. Let me know what you think, @jashapiro |
This looks like it might be at the stage where it's good to split this up into multiple pull requests to make it easier to review. The VAF filter experiment and comparison of callers seem like natural parts to break up and perhaps the small changes here and there can be split up in some logical way. What do you say @cansavvy and @jashapiro ? |
Yes this is what my plan for today has been. Should have noted that on here. This PR grew a bit out of control. |
When breaking it up, I would consider what smaller changes would not necessarily benefit from considerable background knowledge about what you've done so far @cansavvy. @jashapiro is a good person to review what steps would really benefit from that prior knowledge. Let's spread review of other things across multiple reviewers. |
Purpose/implementation
After my initial series of PRs with scripts to assess snv callers individually, this PR adds the notebook which takes that initial analysis and compares the snv callers to each other.
The eventual goal is to decide on a set of mutations from these callers that we can move forward with.
Two things to keep in mind about the current notebook/PR:
Issue
For SNV caller comparison #161, #103 and Tumor Mutation Burden #3 and sort of #11
Directions for reviewers
I'm looking for an initial "broad strokes feedback" about the plots and analyses:
You can see the output notebook here to evaluate my initial questions: https://cansavvy.github.io/openpbta-notebook-concept/snv-callers/compare_snv_callers.nb.html
Some questions for this PR:
Which plots are useful? Which are not?
What do you think of the current analyses?
Are there other analyses you would like to see added?
How do you feel about the plots' aesthetics?
Results
See the rough draft of this notebook output from this notebook here: https://cansavvy.github.io/openpbta-notebook-concept/snv-callers/compare_snv_callers.nb.html
Preliminary conclusion:
From just the subset data it looks like VarDict should be dropped and we could move forward with mutations that are found in Mutect2, Strelka2, and Lancet.
But, we should see how this looks after the v6 data come out and the rest of the samples are added. As of now, we do not have WXS samples for Lancet or VarDict.
Docker and continuous integration
Main RPackages added to the Dockerfile: