-
Notifications
You must be signed in to change notification settings - Fork 67
SNV caller analysis part 1 revamp #172
SNV caller analysis part 1 revamp #172
Conversation
…cansav09/snv_calculations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As as making your template flexible, you could break it into pieces. One file with the main section, one file with the region analysis section, then a session info section file. You would then cat them together on the fly. But I don't necessarily think that is worth the effort, especially for this stage of analysis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a couple little things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
Purpose/implementation
This PR implements a few smaller changes that were initially discussed and implemented on a retired PR #159.
Changes in this PR:
optparse
option in both01-calculate_tmb_vaf.R
and in02-run_eval.R
--no_region
option inrun_caller_evals.sh
Issue
For SNV caller comparison #161, #103 and Tumor Mutation Burden #3 and sort of #11
Directions for reviewers
Are these changes implemented well?
Does everything seem to be in order?
Is there a better way for me to have the non-regional report as opposed to having a whole other copy of that template? I do not like having the whole thing repeated but am unsure as to an alternative?
Results
No new results from these changes.
Docker and continuous integration
*These changes do not require new packages or new CircleCI tests. *