This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-update `release-notes.md` -update `data-files-description.md` -update `data-formats.md`
add new folder for V14 to download scipt
cansavvy
reviewed
Feb 4, 2020
per @cansavvy [comment](#432 (comment))
and description from @cansavvy [comments](#507 (comment))
- add removal of polyA+stranded samples that were still in file in v13
@jaclyn-taroni I will work on #456 tonight. The data is now on s3, and download confirmed to work. Implemented @cansavvy changes in the docs. Ready for review! |
jharenza
added
the
ready for review
Used to label pull requests that are ready for review
label
Feb 4, 2020
@jaclyn-taroni I updated the |
yes, correct! |
readme update for upcoming lancet MAF per issue [here](#512)
We are re-running Lancet for TCGA, per the comment here - will update here once completed and updated on S3. |
yup, nice catch Co-Authored-By: Jaclyn Taroni <jaclyn.n.taroni@gmail.com>
fix embryonal broad histology
jaclyn-taroni
approved these changes
Feb 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was referenced Feb 8, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What scientific question is your analysis addressing?
Update v14 release docs
release-notes.md
data-files-description.md
data-formats.md
What GitHub issue does your pull request address?
#432
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Do the docs look sufficient/am I missing anything?
Is there anything that you want to discuss further?
I updated the links to the D3b workflow repo because we renamed it for consistency with other repos and to not mix other publication workflows with this one.
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes for docs - want to get OK so we can add these to S3.
No for data download.
Data Release Checklist