-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync changes from development
with main
for v0.8.0
#728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…annotation columns to retain
… NA confusion, especially with singler which CAN assign NAs
…pes-during-merge Keep cell type columns when merging
…metadata-from-merged
…olumns-when-merging Retain filter columns when merging
…data-gene_ids Don't rename rowdata `gene_ids` column
…in-check Fix merge.nf workflow adt and multiplex check
…e-unlassified Actually remove unclassified cells from heatmap
…er a string, or named vector if there are multiple samples (multiplex)
Co-authored-by: Stephanie Spielman <stephanie.spielman@gmail.com>
…w-figure Update overview figure
Add nextflow_schema.json file
Co-authored-by: Stephanie Spielman <stephanie.spielman@gmail.com>
Handle empty sample type columns and add sentence about references not having tumor cells
Use `mem_max` for all merging and sync changes from `main`
Update version tag and scpcaTools container
updates: - [github.com/astral-sh/ruff-pre-commit: v0.3.0 → v0.3.2](astral-sh/ruff-pre-commit@v0.3.0...v0.3.2) - [github.com/pre-commit/mirrors-prettier: v3.0.3 → v4.0.0-alpha.8](pre-commit/mirrors-prettier@v3.0.3...v4.0.0-alpha.8)
jashapiro
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I had one tiny suggestion because of #729 (which I think we should otherwise just close)
.pre-commit-config.yaml
Outdated
@@ -30,7 +32,7 @@ repos: | |||
args: [--update-only, --title=**Table of Contents**] | |||
- repo: https://github.com/astral-sh/ruff-pre-commit | |||
# Ruff for linting and formatting python | |||
rev: v0.2.1 | |||
rev: v0.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the precommit ci just suggested this change...
Suggested change
rev: v0.3.0 | |
rev: v0.3.2 |
[pre-commit.ci] pre-commit autoupdate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #654, this syncs all changes from
development
tomain
. This includes the merge workflow, updates to cell typing, and rds file compression.