Fix bugs for dealing with processed objects with only 1 cell #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jashapiro
reviewed
Apr 25, 2024
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
|
@jashapiro are we okay with the decision to not create a supplemental report? I just want to be sure before I merge this and then update the current release. |
Yes, I am fine with that decision! |
Can you approve please? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While processing data for the Portal, I found an object that only has 1 cell in the processed object so it tested out some of the code we added to handle that scenario. There were a few issues that I had to fix to get this to work and then I also made a design change that we will need to decide on if it's the right move or not.
has_clustersvariable to make sure no plots that use clusters are created.add_celltypes_to_sce.Rwhere we were still attempting to add in cell type annotations if the predictions file was empty. So I adjusted the logic there to account for the missing file properly.The other thing I did was choose to not create the supplemental report if there's only 1 cell in the object. The report was just some text with one table showing the assignment of that single cell in SingleR, but no other plots. This doesn't seem super informative to me, and we would still have the table in the main QC report. What do others think of this choice? This should not affect very many samples, but we would want to make sure we check how this affects zipping up the files for the Portal.
@davidsmejia Would you guys have to make changes when zipping up the files for the Portal if a sample was missing the
celltype-report.htmlfile? I assume you have checks to make sure the files are all there, so would we be able to make the existence of this file optional?