Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs for dealing with processed objects with only 1 cell #755

Merged
merged 7 commits into from
Apr 25, 2024
Merged

Fix bugs for dealing with processed objects with only 1 cell #755

merged 7 commits into from
Apr 25, 2024

Commits on Apr 24, 2024

  1. add boolean for if clusters exist

    @allyhawkins
    allyhawkins committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    7b99606 View commit details
    Browse the repository at this point in the history

  2. account for missing predictions

    @allyhawkins
    allyhawkins committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    1a7a282 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. move addition of has_clusters to correct report

    @allyhawkins
    allyhawkins committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    8d5799f View commit details
    Browse the repository at this point in the history

  2. put clusters definition into main report

    @allyhawkins
    allyhawkins committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1ff240c View commit details
    Browse the repository at this point in the history

  3. make sure has_celltypes is in supplemental

    @allyhawkins
    allyhawkins committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2d3d30f View commit details
    Browse the repository at this point in the history

  4. only create supplemental if > 1 cell in object

    @allyhawkins
    allyhawkins committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    c74328a View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
    @allyhawkins @jashapiro
    allyhawkins and jashapiro authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ca62f47 View commit details
    Browse the repository at this point in the history