Delete duplicate layer in AnnData objects #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
Fix bugs for dealing with processed objects with only 1 cell
…int-sizes Define umap point size when creating cell type umaps
Fix some merge bugs
allyhawkins
approved these changes
May 9, 2024
jashapiro
added a commit
to AlexsLemonade/OpenScPCA-nf
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on OpenScPCA-nf, I found that when we move raw data in the processed data, we are leaving in place the original "logcounts" layer, making it meaning we have two copies of it around.
This PR removes that duplication (and merges in changes from
maintodevelopment)Unless we were supposed to leave it for some reason, I think it should save us some space! By my metrics (and logical expectation, nice when they match) this saves ~1/3 of the space for the AnnData processed objects.
I couldn't find any reference to the
layersin our docs, so this change should not require any updates there.