Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #1759 baiji-group 264-2 #1801

Closed

Conversation

panzaiyu
Copy link
Contributor

Ⅰ. Describe what this PR did

Add unit-test for getConflictConfigurations method

Ⅱ. Does this pull request fix one issue?

fixes #1759

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

@panzaiyu Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @panzaiyu
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #1801 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1801      +/-   ##
==========================================
+ Coverage    56.3%   56.46%   +0.15%     
==========================================
  Files         200      200              
  Lines       15657    15657              
==========================================
+ Hits         8816     8841      +25     
+ Misses       5745     5724      -21     
+ Partials     1096     1092       -4
Flag Coverage Δ
#critest 33.52% <ø> (+0.04%) ⬆️
#integrationtest 37.7% <ø> (+0.04%) ⬆️
#unittest 20.41% <ø> (+0.08%) ⬆️
Impacted Files Coverage Δ
cri/v1alpha2/cri.go 66.13% <0%> (+0.17%) ⬆️
daemon/mgr/container.go 53.46% <0%> (+0.31%) ⬆️
ctrd/container.go 50.17% <0%> (+1.37%) ⬆️
ctrd/image.go 79.2% <0%> (+2.47%) ⬆️
daemon/config/config.go 35.8% <0%> (+13.58%) ⬆️

@panzaiyu panzaiyu changed the title Add unit-test for getConflictConfigurations method fix issue #1759 baiji-group 264-2 Jul 24, 2018
@zhuangqh zhuangqh closed this Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for daemon/config/getConfigurations
5 participants