Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[help wanted] add unit-test for daemon/config/getConfigurations #1759

Closed
starnop opened this issue Jul 21, 2018 · 0 comments · Fixed by #1851
Closed

[help wanted] add unit-test for daemon/config/getConfigurations #1759

starnop opened this issue Jul 21, 2018 · 0 comments · Fixed by #1851
Labels
areas/test

Comments

@starnop
Copy link
Contributor

starnop commented Jul 21, 2018 •
edited
Loading

Ⅰ. Issue Description

Add unit-test for getConflictConfigurations method which locate on daemon/config/config.go.

You can take env_test.go for reference.

Ⅱ. Describe what happened

Ⅲ. Describe what you expected to happen

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

please "Baiji" developer refer to this issue in your PR for the convenience for us to count your score.

Ⅵ. Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@zhyzhyzhy zhyzhyzhy mentioned this issue Jul 23, 2018
Closed
lyletang added a commit to lyletang/pouch that referenced this issue Jul 23, 2018
@lyletang
modify AliyunContainerService#1759
a8d4d2c
lyletang added a commit to lyletang/pouch that referenced this issue Jul 23, 2018
@lyletang
fix AliyunContainerService#1759 group=264-3
6d56efd
lyletang added a commit to lyletang/pouch that referenced this issue Jul 23, 2018
@lyletang
fix AliyunContainerService#1759 group=264-3
b94c866
lyletang added a commit to lyletang/pouch that referenced this issue Jul 23, 2018
@lyletang
fix AliyunContainerService#1759 group=264-3
f1a7c1f 
Signed-off-by: lyletang <986537890@qq.com>
@panzaiyu panzaiyu mentioned this issue Jul 23, 2018
Closed
@sunzeyucmu sunzeyucmu mentioned this issue Jul 23, 2018
Closed
@panzaiyu panzaiyu mentioned this issue Jul 23, 2018
Closed
@ljjseu ljjseu mentioned this issue Jul 24, 2018
Closed
@whispervince whispervince mentioned this issue Jul 24, 2018
Closed
@simonla simonla mentioned this issue Jul 24, 2018
Closed
jiapengcs added a commit to jiapengcs/pouch that referenced this issue Jul 24, 2018
@jiapengcs
fixes AliyunContainerService#1759 baiji-group=264-3
00458cf
@SeaRise SeaRise mentioned this issue Jul 24, 2018
Closed
@jiapengcs jiapengcs mentioned this issue Jul 24, 2018
Closed
@simonla simonla mentioned this issue Jul 24, 2018
Closed
@SeaRise SeaRise mentioned this issue Jul 24, 2018
Merged
yangkw pushed a commit to alibaba-plan/pouch that referenced this issue Jul 24, 2018
fixed issue AliyunContainerService#1759
276d2f3 
Signed-off-by: 杨凯文 <kevin@yangkaiwendeMacBook-Pro.local>
jiapengcs added a commit to jiapengcs/pouch that referenced this issue Jul 24, 2018
@jiapengcs
fixes AliyunContainerService#1759 baiji-group=264-3
5aed1af
yangkw pushed a commit to alibaba-plan/pouch that referenced this issue Jul 24, 2018
fix issue AliyunContainerService#1759 this code will run timeout for …
2f70453 
…unknown reason.please check it

Signed-off-by: 杨凯文 <kevin@yangkaiwendeMacBook-Pro.local>
@jiapengcs jiapengcs mentioned this issue Jul 24, 2018
Closed
@yangkw yangkw mentioned this issue Jul 24, 2018
Closed
jiapengcs added a commit to jiapengcs/pouch that referenced this issue Jul 24, 2018
@jiapengcs
fixes AliyunContainerService#1759 baiji-group=264-3
199ad71
jiapengcs added a commit to jiapengcs/pouch that referenced this issue Jul 24, 2018
@jiapengcs
fixes AliyunContainerService#1759 baiji-group=264-3
ecb8be1
@jiapengcs jiapengcs mentioned this issue Jul 24, 2018
Closed
@zhyzhyzhy zhyzhyzhy mentioned this issue Jul 24, 2018
Closed
@YitianChen1996 YitianChen1996 mentioned this issue Jul 24, 2018
Closed
@yannanyue yannanyue mentioned this issue Jul 24, 2018
Closed
@simonla simonla mentioned this issue Jul 24, 2018
Closed
@shuaidongshuai shuaidongshuai mentioned this issue Jul 24, 2018
Closed
@sunzeyucmu sunzeyucmu mentioned this issue Jul 24, 2018
Closed
jiapengcs added a commit to jiapengcs/pouch that referenced this issue Jul 24, 2018
@jiapengcs
fixes AliyunContainerService#1759 baiji-group=264-3
b1ca4f0
@jiapengcs jiapengcs mentioned this issue Jul 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
areas/test
Projects
None yet
Milestone
No milestone
2 participants
@starnop @pouchrobot