Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit test case for func getConflictConfigurations #1837

Conversation

whispervince
Copy link

Ⅰ. Describe what this PR did

Add unit-test for func getConflictConfigurations

Ⅱ. Does this pull request fix one issue?

Fixes #1759

Ⅲ. Describe how you did it

Implement test cases for different possible scenarios of func getConflictConfigurations

Ⅳ. Describe how to verify it

Run go test under daemon/config/

Ⅴ. Special notes for reviews

Team 10

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @whispervince
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2018

CLA assistant check
All committers have signed the CLA.

Signed-off-by: whisper_ <vincentleelwx@gmail.com>
@whispervince whispervince force-pushed the add_unit_test_for_get_conflict_configurations branch from 195dabf to bf0df3c Compare July 24, 2018 03:06
@codecov-io
Copy link

codecov-io commented Jul 24, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@afc7a21). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1837   +/-   ##
=========================================
  Coverage          ?   49.78%           
=========================================
  Files             ?      284           
  Lines             ?    18702           
  Branches          ?        0           
=========================================
  Hits              ?     9311           
  Misses            ?     8268           
  Partials          ?     1123
Flag Coverage Δ
#critest 33.52% <ø> (?)
#integrationtest 37.72% <ø> (?)
#unittest 20.39% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc7a21...bf0df3c. Read the comment docs.

@fuweid fuweid closed this Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for daemon/config/getConfigurations
5 participants