Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1759 baiji-group=264-3 #1870

Closed
wants to merge 1 commit into from

Conversation

jiapengcs
Copy link
Contributor

Ⅰ. Describe what this PR did

add unit-test for daemon/config/getConfigurations

Ⅱ. Does this pull request fix one issue?

fixes #1759

Ⅲ. Describe how you did it

implement function TestGetConflictConfigurations in config_test.go

Ⅳ. Describe how to verify it

unit test, run go test -test.run GetConflictConfigurations

Ⅴ. Special notes for reviews

None

@pouchrobot
Copy link
Collaborator

@jiapengcs Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @jiapengcs
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@pouchrobot
Copy link
Collaborator

ping @jiapengcs
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

@zhuangqh zhuangqh closed this Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for daemon/config/getConfigurations
3 participants